Uploaded image for project: 'Zapped: AcousticBrainz'
  1. Zapped: AcousticBrainz
  2. AB-390

Datasets uploaded with csv import are always made public

XMLWordPrintable

      The dataset csv import page (https://acousticbrainz.org/datasets/import) lets you load a csv file containing metadata for a dataset, but it always creates a public dataset.

      The new dataset page lets you choose if it's public of private, so we should have the same option on the import page.

        1. image-2020-03-30-23-02-19-102.png
          image-2020-03-30-23-02-19-102.png
          222 kB
        2. Screenshot from 2020-03-30 15-57-05.png
          Screenshot from 2020-03-30 15-57-05.png
          226 kB
        3. Screenshot from 2020-03-30 22-00-44.png
          Screenshot from 2020-03-30 22-00-44.png
          231 kB

          [AB-390] Datasets uploaded with csv import are always made public

          Alastair Porter added a comment -

          Fixed and released. Thanks sweta05!

          Alastair Porter added a comment - Fixed and released. Thanks sweta05 !

          GitHub Bot added a comment -

          See code changes in pull request #367 submitted by swetavooda.

          GitHub Bot added a comment - See code changes in pull request #367 submitted by swetavooda .

          Sweta Vooda added a comment - - edited

          Yeah, I agree I tried to do that but using the current class for the CSS formatting it was becoming chaos so I tried doing this.However it looks like this now. 

          Sweta Vooda added a comment - - edited Yeah, I agree I tried to do that but using the current class for the CSS formatting it was becoming chaos so I tried doing this.However it looks like this now. 

          Alastair Porter added a comment -

          It would be nice to make this look like the "create dataset" page. In that case, the checkbox is first, and the label after.
          Otherwise it looks fine. Looking forward to seeing your PR!

          Alastair Porter added a comment - It would be nice to make this look like the "create dataset" page. In that case, the checkbox is first, and the label after. Otherwise it looks fine. Looking forward to seeing your PR!

          Sweta Vooda added a comment -

          I worked on this and the functionality works well. However, I am doubtful of the front end. Please look at it and let me know if this is fine?

           

          Sweta Vooda added a comment - I worked on this and the functionality works well. However, I am doubtful of the front end. Please look at it and let me know if this is fine?  

            sweta05 Sweta Vooda
            alastairp Alastair Porter
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                v-2020-04-20.0