Uploaded image for project: 'BookBrainz'
  1. BookBrainz
  2. BB-337

It shouldn't be possible to save a revision with no changes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Site Backend
    • Labels:
    • Size Estimate:
      House

      Description

      To reproduce the issue follow this steps -

      1. add a new work to BB followed by clicking on submit
      2. visit the newly created work and then click on edit.
      3. The edit page opens, try to submit the edit page without any revised details
      4. The revision is accepted without any actual update to the work.

      The part of the code the should be responsible for preventing that is here:
      https://github.com/bookbrainz/bookbrainz-site/blob/07fd0f62bda21146d466c7fbcc06e20bcd10237c/src/server/routes/entity/entity.js#L704-L707

        Attachments

        1. bb337.jpeg
          bb337.jpeg
          58 kB
        2. revision_bug.png
          revision_bug.png
          100 kB
        3. work.png
          work.png
          95 kB

          Activity

            People

            • Assignee:
              prabalsingh24 Prabal Singh
              Reporter:
              rihan27 rihan pereira
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package