-
Bug
-
Resolution: Fixed
-
Normal
-
None
-
None
-
None
-
None
While try to create an Edition from a Work page, The error below was thrown by the server, resulting in a 500 error on the web page.
This line breaks if releaseDateValue is undefined. A safe getter should be used instead, like lodash's _.get or _.has
https://github.com/bookbrainz/bookbrainz-site/blob/3afd5648a96d51af4d18ad881da8eaa3f7e4e1fd/src/client/entity-editor/edition-section/edition-section.js#L239
[Tue Jun 11 2019 16:46:21 GMT+0000 (Coordinated Universal Time)] ERROR TypeError: Cannot read property 'day' of undefined at EditionSection (/home/bookbrainz/bookbrainz-site/lib/client/entity-editor/edition-section/edition-section.js:206:31) at processChild (/home/bookbrainz/bookbrainz-site/node_modules/react-dom/cjs/react-dom-server.node.development.js:2138:14) at resolve (/home/bookbrainz/bookbrainz-site/node_modules/react-dom/cjs/react-dom-server.node.development.js:2064:5) at ReactDOMServerRenderer.render (/home/bookbrainz/bookbrainz-site/node_modules/react-dom/cjs/react-dom-server.node.development.js:2383:22) at ReactDOMServerRenderer.read (/home/bookbrainz/bookbrainz-site/node_modules/react-dom/cjs/react-dom-server.node.development.js:2357:19) at Object.renderToString (/home/bookbrainz/bookbrainz-site/node_modules/react-dom/cjs/react-dom-server.node.development.js:2729:25) at entityEditorMarkup (/home/bookbrainz/bookbrainz-site/lib/server/helpers/entityRouteUtils.js:168:34) at render (/home/bookbrainz/bookbrainz-site/lib/server/routes/entity/edition.js:189:65) From previous event: at router.get (/home/bookbrainz/bookbrainz-site/lib/server/routes/entity/edition.js:200:41) at Layer.handle [as handle_request] (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/layer.js:95:5) at next (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/route.js:137:13) at Child.model.fetchAll.then.results (/home/bookbrainz/bookbrainz-site/lib/server/helpers/middleware.js:57:4) at runCallback (timers.js:705:18) at tryOnImmediate (timers.js:676:5) at processImmediate (timers.js:658:5) From previous event: at loaderFunc (/home/bookbrainz/bookbrainz-site/lib/server/helpers/middleware.js:52:27) at Layer.handle [as handle_request] (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/layer.js:95:5) at next (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/route.js:137:13) at isAuthenticated (/home/bookbrainz/bookbrainz-site/lib/server/helpers/auth.js:132:10) at Layer.handle [as handle_request] (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/layer.js:95:5) at next (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/route.js:137:13) at Route.dispatch (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/route.js:112:3) at Layer.handle [as handle_request] (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/layer.js:95:5) at /home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:281:22 at Function.process_params (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:335:12) at next (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:275:10) at /home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:277:16 at param (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:350:14) at paramCallback (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:397:7) at /home/bookbrainz/bookbrainz-site/lib/server/helpers/middleware.js:146:10 at paramCallback (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:404:7) at param (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:384:5) at Function.process_params (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:410:3) at next (/home/bookbrainz/bookbrainz-site/node_modules/express/lib/router/index.js:275:10) GET /edition/create?work=391c39ef-65f7-425d-98ee-dfa7023fea6c 500 334.635 ms - -