Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-749

Avoid mutating state to update recording feedback

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None
    • None

      There are instances in recording feedback where we mutate states to update them.
      This should be avoided for the given reasons:
      1. We make a copy of and modify the state (so that react detects a change).
      2. We make sure we're not overwriting parts of the state inadvertantly (the calls to setState are asynchronous).

            mr_monkey Monkey
            shivam-kapila Shivam Kapila
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package