Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-12815

Generated edit search link for URL relationships with pending edits contains JavaScript

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2023-12-20
    • None
    • Edit search
    • None

      I just wanted to edit the relationship type of a pending URL relationship and the warning link it presented me leads to a weird edit search where an autocomplete input is prefilled with JavaScript code:

      Warning: This relationship has pending edits. Click here to view these edits and make sure they do not conflict with your own.

      Furthermore, according to the query parameters, the second condition should not be for the field ID but for the field URL, which is not even an option you can choose in the dropdown. I would have expected the value input to contain the URL, but it looks like URL entities were not considered when the edit search filter was designed. (Apart from URL and Genre, all other entity types are present in the dropdown.)

      P.S. While this looks weird, the search works just as expected.

        1. image-2023-01-03-21-37-19-128.png
          image-2023-01-03-21-37-19-128.png
          154 kB

          [MBS-12815] Generated edit search link for URL relationships with pending edits contains JavaScript

          Nicolás Tamargo added a comment -

          The code bit seems to be some issue with knockout that does not happen in beta anymore, so probably solved by the change to the new relationship editor.

          Nicolás Tamargo added a comment - The code bit seems to be some issue with knockout that does not happen in beta anymore, so probably solved by the change to the new relationship editor.

          GitHub Bot added a comment -

          See code changes in pull request #2793 submitted by reosarevok.

          GitHub Bot added a comment - See code changes in pull request #2793 submitted by reosarevok .

          Nicolás Tamargo added a comment -

          Genre is actually present in beta, but URL is not and should be added. I'll also look into how that function ended up as the name

          Nicolás Tamargo added a comment - Genre is actually present in beta, but URL is not and should be added. I'll also look into how that function ended up as the name

            reosarevok Nicolás Tamargo
            kellnerd David Kellner
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2023-12-20