Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-12866

Make grouping relationship types more visible in dropdowns

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Relationship editor
    • None

      "The grouping (or headlines) of the relationships in these droplist could be clearer though. Light-grey headlines are hard to spot when the rest is black" (by joiletjake, from https://community.metabrainz.org/t/help-test-the-relationship-editor-on-beta-musicbrainz-org/621824/29)

        1. arrow-right-classic-tail.png
          arrow-right-classic-tail.png
          0.3 kB
        2. arrow-right-classic-tail.svg
          1 kB
        3. image-2023-03-07-13-15-34-056.png
          image-2023-03-07-13-15-34-056.png
          67 kB
        4. image-2023-05-16-18-42-49-954.png
          image-2023-05-16-18-42-49-954.png
          63 kB
        5. img3.png
          img3.png
          197 kB
        6. img3-1.png
          img3-1.png
          197 kB
        7. MBS-12866 00 current.png
          MBS-12866 00 current.png
          35 kB
        8. MBS-12866 01 darker.png
          MBS-12866 01 darker.png
          35 kB
        9. MBS-12866 02 bold.png
          MBS-12866 02 bold.png
          36 kB
        10. MBS-12866 03 more indent.png
          MBS-12866 03 more indent.png
          35 kB
        11. MBS-12866 04 highlights.png
          MBS-12866 04 highlights.png
          35 kB
        12. MBS-12866 05 highlights and drop downs.png
          MBS-12866 05 highlights and drop downs.png
          36 kB
        13. MBS-12866 06 faint line.png
          MBS-12866 06 faint line.png
          35 kB
        14. MBS-12866 07 vertical line.png
          MBS-12866 07 vertical line.png
          35 kB
        15. MBS-12866 08 arrows.png
          MBS-12866 08 arrows.png
          35 kB

          [MBS-12866] Make grouping relationship types more visible in dropdowns

          Monkey added a comment - Sorry I missed that reosarevok Here's the CSS code for it: https://github.com/metabrainz/bookbrainz-site/blob/adaed6712ffc0db981924989afea0cfd41efe235/src/client/stylesheets/style.scss#L880-L890 And it is used like so: https://github.com/metabrainz/bookbrainz-site/blob/adaed6712ffc0db981924989afea0cfd41efe235/src/client/entity-editor/work-section/work-section.tsx#L121

          Seems good to me, mr_monkey - do you have some code for the BB implementation that we can... 😎 ape?

          Nicolás Tamargo added a comment - Seems good to me, mr_monkey - do you have some code for the BB implementation that we can... 😎 ape?

          Aerozol added a comment -

          Looking good to me

          Aerozol added a comment - Looking good to me

          ShivamAwasthi added a comment -

          I think it looks very good and will be appropriate for showing relationships too. Great job!

          ShivamAwasthi added a comment - I think it looks very good and will be appropriate for showing relationships too. Great job!

          Monkey added a comment -

          I ran into the same need for BB again, and have this suggested implementation based on the mockup #8

          It uses some simple css borders instead of the icons, which I think ended up being too big and chucky (at least the FontAwesome icons).

          Feedback welcome !

          Monkey added a comment - I ran into the same need for BB again, and have this suggested implementation based on the mockup #8 It uses some simple css borders instead of the icons, which I think ended up being too big and chucky (at least the FontAwesome icons). Feedback welcome !

          ShivamAwasthi added a comment -

          This is how it looks like with the new icon. I think it will look even better if the color of the icon can be made something like #41413C.

          What do you guys think?

          ShivamAwasthi added a comment - This is how it looks like with the new icon. I think it will look even better if the color of the icon can be made something like #41413C. What do you guys think?

          Aerozol added a comment -

          Arrow 'with tail' based on the fontawesome icon set. Small change but it may make a difference:


          + arrow-right-classic-tail.svg

          Not sure if these formats suit, let me know if others are needed.

          Aerozol added a comment - Arrow 'with tail' based on the fontawesome icon set. Small change but it may make a difference: + arrow-right-classic-tail.svg Not sure if these formats suit, let me know if others are needed.

          Aerozol added a comment - - edited

          @ShivamAwasthi has drafted the following over on BB:

          Which I think looks nice (and sticks to their icon set). I would like to try modifying it to have a little bit pointing up on the 'tail', then I will share the icon files here.

          Edit: Needed to proceed, the icon file shown above.

          Aerozol added a comment - - edited @ShivamAwasthi has drafted the following over on BB: Which I think looks nice (and sticks to their icon set). I would like to try modifying it to have a little bit pointing up on the 'tail', then I will share the icon files here. Edit: Needed to proceed, the icon file shown above.

          Aerozol added a comment -

          General consensus is for mockup #8, which I am happy to have implemented/assigned to someone.
          The connection graphic should be easy to change if someone thinks of a better way to do it in the future.

          Aerozol added a comment - General consensus is for mockup #8, which I am happy to have implemented/assigned to someone. The connection graphic should be easy to change if someone thinks of a better way to do it in the future.

          Aerozol added a comment -

          Reply from joiletjake in the forums:
          Looks pretty good, I personally currently prefer the ones where the difference is more obvious: different background in 4 & 5 and the lines in 7 & 8 (all of these also works best when zoomed out). It also looks a bit weird that the headline “performance” and the selectable “arranged/arranger” currently is on the same level. You’ve also highlighted how bad the indentation currently is, so increasing that is a minimum imo if you decide to do any changes, because it really helps a lot when distinguishing between the different options. Increasing the indentation + make sure that the headlines are not on the same level as selectable options might be the way forward? “Bold” is afaict now used to show the selected item, which I like because it matches how the relationships are shown after the pop-up window is closed, but this also means that it probably is not a good idea to make the headline “bold”. I also have no idea if you plan to introduce more colours here in the upcoming redesign, which could be an additional option to somehow make the distinction a bit clearer.

          Aerozol added a comment - Reply from joiletjake in the forums: Looks pretty good, I personally currently prefer the ones where the difference is more obvious: different background in 4 & 5 and the lines in 7 & 8 (all of these also works best when zoomed out). It also looks a bit weird that the headline “performance” and the selectable “arranged/arranger” currently is on the same level. You’ve also highlighted how bad the indentation currently is, so increasing that is a minimum imo if you decide to do any changes, because it really helps a lot when distinguishing between the different options. Increasing the indentation + make sure that the headlines are not on the same level as selectable options might be the way forward? “Bold” is afaict now used to show the selected item, which I like because it matches how the relationships are shown after the pop-up window is closed, but this also means that it probably is not a good idea to make the headline “bold”. I also have no idea if you plan to introduce more colours here in the upcoming redesign, which could be an additional option to somehow make the distinction a bit clearer.

            Unassigned Unassigned
            reosarevok Nicolás Tamargo
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:

                Version Package