Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-12930

Beta: Seeded rel with no type set can be submit, ISEs

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • Beta
    • None
    • Relationship editor
    • None

      It's currently possible to seed an entity for a rel (but not a reltype), such as in https://beta.musicbrainz.org/work/create?rels.0.target=c0d0eb40-2959-4770-8202-b3358852a570 - If a work name is entered, the form can be submitted with the reltype still unset, which unsurprisingly fails horribly. We should probably catch these with validation and block the submission or at least return a proper error.

      Sentry Issue: MUSICBRAINZ-SERVER-3GE

      None:  is not a type that has a model at lib/MusicBrainz/Server/Data/Utils.pm line 449.
        File "Utils.pm", line 449, in MusicBrainz::Server::Data::Utils::type_to_model
          return $TYPE_TO_MODEL{$_[0]} || die "$_[0] is not a type that has a model";
        File "EditRelationships.pm", line 72, in MusicBrainz::Server::Controller::Role::EditRelationships::load_entities
          push @{ $entity_map->{type_to_model($target_type)} //= [] }, $field->{target};
        File "EditRelationships.pm", line 387, in MusicBrainz::Server::Controller::Role::EditRelationships::__ANON__::SERIAL::119::edit_relationships
          my $entity_map = load_entities($c, ref_to_type($source), @field_values);
        File "EditRelationships.pm", line 372, in MusicBrainz::Server::Controller::Role::EditRelationships::__ANON__
          my $rel_changes = $self->edit_relationships($c, $form, \@rels, $source);
        File "Controller.pm", line 179, in Sql::run_in_transaction
          if exists $opts{post_creation};
      ...
      (9 additional frame(s) were not displayed)
      

            reosarevok Nicolás Tamargo
            dev-sentry Dev through Sentry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                Beta