Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-13579

Seeding release labels for an existing release is only rarely working

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2024-07-22
    • None
    • Release editor
    • None

      I am not aware of any tool which supports seeding updates for an existing release, but yambs allows you to do it and it works fine for most fields.

      When I attempted to POST a release seed which contains labels, I failed to make it work in a meaningful way. If we assume that the target release currently has label A, there are three basic use cases:

      1. Replace label A by label B: Seeding only label B gives the desired result.
      2. Remove label A: Apparently not possible, seeding no label keeps the existing data intact.
      3. Keep label A and add label B: Seeding label A and label B seems to be the obvious choice, but this causes the edit preview to fail silently with HTTP 400: {"error":"The label and catalog number in this edit already exist on the release."}

      While I can live with the behavior in case 2, the last case is very annoying as the eror is neither displayed nor fixable by the user. Removing the visible "duplicate" label A willl enter an edit to remove it and there is no way to get the "original" label A back.

      P.S. I had expected external links to have the same issue, but for these the seeded ones are always added in addition to the existing ones.

          [MBS-13579] Seeding release labels for an existing release is only rarely working

          GitHub Bot added a comment -

          See code changes in pull request #3260 submitted by mwiencek.

          GitHub Bot added a comment - See code changes in pull request #3260 submitted by mwiencek .

          David Kellner added a comment -

          Just as a quick reference, here are the yambs parameters which I used for testing (case 3):

          mbid=88365421-f213-4715-a1b7-8144ce950c6d
          label0_mbid=0acc7c46-8f5f-4ea5-9429-a029bfd718c0
          label1_mbid=6789893a-0346-4ab0-8519-2c97f428ebc7

          David Kellner added a comment - Just as a quick reference, here are the yambs parameters which I used for testing (case 3): mbid=88365421-f213-4715-a1b7-8144ce950c6d label0_mbid=0acc7c46-8f5f-4ea5-9429-a029bfd718c0 label1_mbid=6789893a-0346-4ab0-8519-2c97f428ebc7

            bitmap Michael Wiencek
            kellnerd David Kellner
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2024-07-22