Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-390

Edit search is missing functionality compared to the pre-NGS edit search

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: High High
    • 2017-04-10
    • NGS - Beta 1
    • Edit search
    • None

      We can search for edits on http://test.musicbrainz.org/search/edits but we're missing most of the options of the current one http://musicbrainz.org/mod/search/index.html

      We're still missing the editor, voter, vote cast, artist, language, auto-edit filters, the sort order and the edit id/time range.

          [MBS-390] Edit search is missing functionality compared to the pre-NGS edit search

          yvanzo added a comment -

          The five still open sub-tasks are now all under review.

          yvanzo added a comment - The five still open sub-tasks are now all under review.

          nikki added a comment -

          MBS-3914 and MBS-3665 are regressions, MBS-3362 is sort of a regression (see the comments for it) and I've converted the rest. There's no need to touch the closed tickets IMO.

          nikki added a comment - MBS-3914 and MBS-3665 are regressions, MBS-3362 is sort of a regression (see the comments for it) and I've converted the rest. There's no need to touch the closed tickets IMO.

          jesus2099 added a comment -

          OK nikki, why not.
          So we should move MBS-4166, MBS-4165, MBS-3914, MBS-3665, MBS-2677, MBS-2664, MBS-3362 out as well (convert to improvements). I can do it.
          And maybe for the record also those closed tickets that are out of scope (that were not in pre-NGS).

          jesus2099 added a comment - OK nikki, why not. So we should move MBS-4166 , MBS-4165 , MBS-3914 , MBS-3665 , MBS-2677 , MBS-2664 , MBS-3362 out as well (convert to improvements). I can do it. And maybe for the record also those closed tickets that are out of scope (that were not in pre-NGS).

          nikki added a comment -

          I've clarified the summary because tickets like this tend to just keep attracting new subtasks outside the original scope of the ticket (which here was to reach feature parity with the pre-NGS search) and we'll never be able to close a ticket if there isn't a point at which we can say it's finished.

          nikki added a comment - I've clarified the summary because tickets like this tend to just keep attracting new subtasks outside the original scope of the ticket (which here was to reach feature parity with the pre-NGS search) and we'll never be able to close a ticket if there isn't a point at which we can say it's finished.

          jesus2099 added a comment - - edited

          Thanks for the answer Oliver, I guess I probably won't be able to remember those subtilities and a generic end date criteria (and/or failed on date and/or applied on date) is then really missing.

          Something else I really don't know where to write it but it feels really important in my way of using MB before NGS :

          Let's say I click a user's edits, I see all his/her edits or her open edits.
          I then used to begin to filter down the edits to progressively only see the wanted edits.
          It is now impossible to begin filtering edits starting from a generic edit search page (entity/mbid/[open_]edits). ← the solution to this would be that clicking user/bob/edits/open would redirect to the appropriate complete detailed search URL (it was how it was done before) and same for /entity/mbid/open_edits → complete search URL ...

          with this goold old Advanced edit search button that was opening the edit search tweaking page with current criterias.

          PS. Notice the inconsistency between /user/bob/edits/open and /entity/mbid/open_edits

          (really sorry for all this spam)

          jesus2099 added a comment - - edited Thanks for the answer Oliver, I guess I probably won't be able to remember those subtilities and a generic end date criteria (and/or failed on date and/or applied on date ) is then really missing. Something else I really don't know where to write it but it feels really important in my way of using MB before NGS : Let's say I click a user's edits, I see all his/her edits or her open edits. I then used to begin to filter down the edits to progressively only see the wanted edits. It is now impossible to begin filtering edits starting from a generic edit search page (entity/mbid/ [open_] edits). ← the solution to this would be that clicking user/bob/edits/open would redirect to the appropriate complete detailed search URL (it was how it was done before) and same for /entity/mbid/open_edits → complete search URL ... with this goold old Advanced edit search button that was opening the edit search tweaking page with current criterias. PS. Notice the inconsistency between /user/bob/ edits/open and /entity/mbid/ open_edits (really sorry for all this spam)

          Well, the expired date is when an edit would expire without any voting (when ModBot can close it), and closed is the date the edit was finally accepted or rejected. There is no way to search both of these fields at the same time, atm

          Oliver Charles added a comment - Well, the expired date is when an edit would expire without any voting (when ModBot can close it), and closed is the date the edit was finally accepted or rejected. There is no way to search both of these fields at the same time, atm

          jesus2099 added a comment -

          We have Closed and Expired (between YYYY-MM-DD and YYYY-MM-DD for instance) criterias.
          Is there one criteria that searches for edit end (whether it is applied/closed/expired/failed/etc.) ?
          Or what is the difference between those two ?

          jesus2099 added a comment - We have Closed and Expired (between YYYY-MM-DD and YYYY-MM-DD for instance) criterias. Is there one criteria that searches for edit end (whether it is applied/closed/expired/failed/etc.) ? Or what is the difference between those two ?

          As this is a grouping ticket, it doesn't make much sense to appear in my iteration. Rather, than the specific subtasks should be moved

          Oliver Charles added a comment - As this is a grouping ticket, it doesn't make much sense to appear in my iteration. Rather, than the specific subtasks should be moved

          Still incomplete since most subtasks are not completed.

          Aurélien Mino added a comment - Still incomplete since most subtasks are not completed.

          Sorry, doubt I can get this done well in 2 days

          Oliver Charles added a comment - Sorry, doubt I can get this done well in 2 days

            yvanzo yvanzo
            nikki nikki
            Votes:
            24 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2017-04-10