Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-4695

Internal Server Error when adding cover art in several tabs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Cover art
    • Labels:
      None

      Description

      Since the delay for adding each cover art image is quite long I opened several instances of http://musicbrainz.org/release/32c3d204-6e49-3c57-8ae2-3d8311a06364/add-cover-art in a few tabs. The first image entered works fine, but after that any edit fails as per below. Obviously, it's the positioning that gets confused, and this ought to also happen if two different editors try adding cover art at the same time. It should instead tell the user that there was a mid-air collision and suggest looking at the position again.

      Internal Server Error

      Oops, something went wrong!

      Error:

      Caught exception in MusicBrainz::Server::Controller::Release->add_cover_art "The edit could not be created.
      POST: $VAR1 =

      { 'add-cover-art.id' => '924793924', 'add-cover-art.type_id' => '3', 'add-cover-art.position' => '38', 'add-cover-art.comment' => 'Follow Angela page 25-26', 'add-cover-art.edit_note' => '', 'add-cover-art.as_auto_editor' => '1' }

      ;

      Exception:$VAR1 = 'Failed query:
      \'INSERT INTO cover_art_archive.cover_art (release, edit, ordering, id, comment)
      VALUES (?, ?, ?, ?, ?)\'
      (292168 17592436 38 924793924 Follow Angela page 25-26)
      DBD::Pg::st execute failed: ERROR: duplicate key value violates unique constraint "cover_art_pkey"
      DETAIL: Key (id)=(924793924) already exists. at lib/Sql.pm line 103.

      at lib/Sql.pm line 109
      Sql::_ANON_(\'DBD::Pg::st execute failed: ERROR: duplicate key value viola...\') called at local/lib/perl5/Try/Tiny.pm line 100
      Try::Tiny::try(\'CODE(0x102b0cf0)\', \'Try::Tiny::Catch=REF(0x102b3140)\') called at lib/Sql.pm line 110
      Sql::do(\'Sql=HASH(0xc72fe90)\', \'INSERT INTO cover_art_archive.cover_art (release, edit, order...\', 292168, 17592436, 38, 924793924, \'Follow Angela page 25-26\') called at lib/MusicBrainz/Server/Data/CoverArtArchive.pm line 90
      MusicBrainz::Server::Data::CoverArtArchive::insert_cover_art(\'MusicBrainz::Server::Data::CoverArtArchive=HASH(0xa951af8)\', 292168, 17592436, 924793924, 38, \'ARRAY(0xe1a6788)\', \'Follow Angela page 25-26\') called at lib/MusicBrainz/Server/Edit/Release/AddCoverArt.pm line 75
      MusicBrainz::Server::Edit::Release::AddCoverArt::post_insert(\'MusicBrainz::Server::Edit::Release::AddCoverArt=HASH(0x10252800)\') called at lib/MusicBrainz/Server/Data/Edit.pm line 408
      MusicBrainz::Server::Data::Edit::_ANON_() called at lib/Sql.pm line 264
      Sql::_ANON_() called at local/lib/perl5/Try/Tiny.pm line 76
      eval

      {...} called at local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try(\'CODE(0x102b7f20)\', \'Try::Tiny::Catch=REF(0x1026ddb0)\') called at lib/Sql.pm line 277
      Sql::_auto_transaction(\'CODE(0x102a6900)\', \'Sql=HASH(0xc72fe90)\') called at lib/Sql.pm line 282
      Sql::_run_in_transaction_one(\'CODE(0x102a6900)\', \'Sql=HASH(0xc72fe90)\') called at lib/Sql.pm line 296
      Sql::run_in_transaction(\'CODE(0x102a6900)\', \'Sql=HASH(0xc72fe90)\') called at lib/MusicBrainz/Server/Data/Edit.pm line 436
      MusicBrainz::Server::Data::Edit::create(\'MusicBrainz::Server::Data::Edit=HASH(0xabe6a10)\', \'editor_id\', 220174, \'privileges\', 1, \'cover_art_types\', \'ARRAY(0xe1a6788)\', \'cover_art_id\', 924793924, ...) called at lib/MusicBrainz/Server/Controller.pm line 85
      MusicBrainz::Server::Controller::_ANON_() called at local/lib/perl5/Try/Tiny.pm line 76
      eval {...}

      called at local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try(\'CODE(0xe1a6b90)\', \'Try::Tiny::Catch=REF(0xe1a4100)\') called at lib/MusicBrainz/Server/Controller.pm line 101
      MusicBrainz::Server::Controller::_insert_edit(\'MusicBrainz::Server::Controller::Release=HASH(0xc1291d0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Form::Release::AddCoverArt=HASH(0xd9134b8)\', \'edit_type\', 314, \'release\', \'MusicBrainz::Server::Entity::Release=HASH(0xddff670)\', \'cover_art_types\', \'ARRAY(0xe1a6788)\', ...) called at lib/MusicBrainz/Server/Controller/Release.pm line 451
      MusicBrainz::Server::Controller::Release::add_cover_art(\'MusicBrainz::Server::Controller::Release=HASH(0xc1291d0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(\'Catalyst::Action=HASH(0xc4cc038)\', \'MusicBrainz::Server::Controller::Release=HASH(0xc1291d0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst.pm line 1667
      eval

      {...} called at local/lib/perl5/Catalyst.pm line 1667
      Catalyst::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4cc038)\') called at local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4cc038)\') called at lib/MusicBrainz/Server.pm line 316
      MusicBrainz::Server::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4cc038)\') called at local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(\'Catalyst::Action=HASH(0xc4cc038)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst/ActionChain.pm line 38
      Catalyst::ActionChain::dispatch(\'Catalyst::ActionChain=HASH(0xd473828)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst/Controller.pm line 125
      Catalyst::Controller::_ACTION(\'MusicBrainz::Server::Controller::Release=HASH(0xc1291d0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(\'Catalyst::Action=HASH(0xc4c61c0)\', \'MusicBrainz::Server::Controller::Release=HASH(0xc1291d0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst.pm line 1667
      eval {...}

      called at local/lib/perl5/Catalyst.pm line 1667
      Catalyst::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4c61c0)\') called at local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4c61c0)\') called at lib/MusicBrainz/Server.pm line 316
      MusicBrainz::Server::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4c61c0)\') called at local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(\'Catalyst::Action=HASH(0xc4c61c0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(\'Catalyst::Dispatcher=HASH(0x42903f0)\', \'forward\', \'MusicBrainz::Server=HASH(0xdd2bff8)\', \'_ACTION\') called at local/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(\'Catalyst::Dispatcher=HASH(0x42903f0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\', \'_ACTION\') called at local/lib/perl5/Catalyst.pm line 342
      Catalyst::forward(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'_ACTION\') called at local/lib/perl5/Catalyst/Controller.pm line 99
      Catalyst::Controller::_DISPATCH(\'MusicBrainz::Server::Controller::Release=HASH(0xc1291d0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(\'Catalyst::Action=HASH(0xc4c5ae8)\', \'MusicBrainz::Server::Controller::Release=HASH(0xc1291d0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst.pm line 1667
      eval

      {...} called at local/lib/perl5/Catalyst.pm line 1667
      Catalyst::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4c5ae8)\') called at local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4c5ae8)\') called at lib/MusicBrainz/Server.pm line 316
      MusicBrainz::Server::execute(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'MusicBrainz::Server::Controller::Release\', \'Catalyst::Action=HASH(0xc4c5ae8)\') called at local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(\'Catalyst::Action=HASH(0xc4c5ae8)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(\'Catalyst::Dispatcher=HASH(0x42903f0)\', \'forward\', \'MusicBrainz::Server=HASH(0xdd2bff8)\', \'/release/_DISPATCH\') called at local/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(\'Catalyst::Dispatcher=HASH(0x42903f0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\', \'/release/_DISPATCH\') called at local/lib/perl5/Catalyst.pm line 342
      Catalyst::forward(\'MusicBrainz::Server=HASH(0xdd2bff8)\', \'/release/_DISPATCH\') called at local/lib/perl5/Catalyst/Dispatcher.pm line 105
      Catalyst::Dispatcher::dispatch(\'Catalyst::Dispatcher=HASH(0x42903f0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst.pm line 1613
      Catalyst::dispatch(\'MusicBrainz::Server=HASH(0xdd2bff8)\') called at lib/MusicBrainz/Server.pm line 280
      Class::MOP::Class:::around(\'CODE(0x3e46ea0)\', \'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(\'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::dispatch(\'MusicBrainz::Server=HASH(0xdd2bff8)\') called at local/lib/perl5/Catalyst.pm line 1963
      Catalyst::_ANON_() called at local/lib/perl5/Try/Tiny.pm line 76
      eval {...}

      called at local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try(\'CODE(0xcd732a0)\', \'Try::Tiny::Catch=REF(0xde0b4e8)\') called at local/lib/perl5/Catalyst.pm line 1969
      Catalyst::handle_request(\'MusicBrainz::Server\', \'env\', \'HASH(0xce57620)\') called at lib/Catalyst/Plugin/AutoRestart.pm line 119
      Catalyst::Plugin::AutoRestart::handle_request(\'MusicBrainz::Server\', \'env\', \'HASH(0xce57620)\') called at local/lib/perl5/Catalyst/Engine.pm line 856
      Catalyst::Engine::_ANON_(\'CODE(0xca24120)\') called at local/lib/perl5/Plack/Handler/FCGI.pm line 134
      Plack::Handler::FCGI::run(\'Plack::Handler::FCGI=HASH(0x22e1a30)\', \'CODE(0xc6921d0)\') called at local/lib/perl5/Plack/Loader.pm line 88
      Plack::Loader::run(\'Plack::Loader=HASH(0x22aae00)\', \'Plack::Handler::FCGI=HASH(0x22e1a30)\') called at local/lib/perl5/Plack/Runner.pm line 263
      Plack::Runner::run(\'Plack::Runner=HASH(0x20ad808)\') called at local/bin/plackup line 10
      at lib/Sql.pm line 277
      ';
      at lib/MusicBrainz/Server/Controller.pm line 101"

      Stack trace:
      line 97 MusicBrainz::Server::Controller
      line 101 MusicBrainz::Server::Controller
      line 451 MusicBrainz::Server::Controller::Release
      line 316 MusicBrainz::Server
      line 316 MusicBrainz::Server
      line 316 MusicBrainz::Server
      line 280 MusicBrainz::Server

      Request data:
      $VAR1 = {
      'query_parameters' => {},
      'body_parameters' =>

      { 'add-cover-art.id' => '924793924', 'add-cover-art.type_id' => '3', 'add-cover-art.edit_note' => '', 'add-cover-art.comment' => 'Follow Angela page 25-26', 'add-cover-art.position' => '38', 'add-cover-art.as_auto_editor' => '1' }

      };

      URL: http://musicbrainz.org/release/32c3d204-6e49-3c57-8ae2-3d8311a06364/add-cover-art

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              foolip Philip Jägenstedt
              Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:

                  Packages

                  Version Package