Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-6065

Internal server error when double submitting an add artist edit

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2015-06-15
    • Component/s: Editing interface
    • Labels:
      None

      Description

      If you accidentally submit the create artist form twice, the first one adds an artist, the second gives an ISE.

      Fehler:

      Caught exception in MusicBrainz::Server::Controller::Artist->create "The edit could not be created.
      POST: $VAR1 =

      Unknown macro: { 'edit-artist.edit_note' => '', 'edit-artist.as_auto_editor' => '1', 'edit-artist.period.end_date.month' => '', 'edit-artist.country_id' => '', 'edit-artist.gender_id' => '', 'edit-artist.period.begin_date.year' => '', 'edit-artist.period.end_date.year' => '', 'edit-artist.ipi_codes.0' => '', 'edit-artist.period.begin_date.month' => '', 'edit-artist.type_id' => '', 'edit-artist.sort_name' => 'temporary test', 'edit-artist.period.end_date.day' => '', 'edit-artist.comment' => '', 'edit-artist.name' => 'temporary test', 'edit-artist.period.begin_date.day' => '' }

      ;

      Exception:$VAR1 = 'DBD::Pg::st execute failed: ERROR: duplicate key value violates unique constraint "artist_idx_uniq_name_comment"
      DETAIL: Key (name, comment)=(1451043, ) already exists. at lib/Sql.pm line 414, line 3.
      at lib/Sql.pm line 429, line 3.
      Sql::_ANON_(\'DBD::Pg::st execute failed: ERROR: duplicate key value viola...\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Try/Tiny.pm line 100
      Try::Tiny::try(\'CODE(0x11433ec0)\', \'Try::Tiny::Catch=REF(0x121e97f0)\') called at lib/Sql.pm line 430
      Sql::_select_list(\'Sql=HASH(0xe4ad7e0)\', \'INSERT INTO artist (country,begin_date_day,name,begin_date_ye...\', \'ARRAY(0xe629d20)\', \'arrayref\', \'CODE(0x609b918)\') called at lib/Sql.pm line 449
      Sql::select_list_of_lists(\'Sql=HASH(0xe4ad7e0)\', \'INSERT INTO artist (country,begin_date_day,name,begin_date_ye...\', undef, undef, 1451043, undef, 0, undef, \'\', ...) called at lib/Sql.pm line 382
      Sql::select_single_column_array(\'Sql=HASH(0xe4ad7e0)\', \'INSERT INTO artist (country,begin_date_day,name,begin_date_ye...\', undef, undef, 1451043, undef, 0, undef, \'\', ...) called at lib/Sql.pm line 397
      Sql::select_single_value(\'Sql=HASH(0xe4ad7e0)\', \'INSERT INTO artist (country,begin_date_day,name,begin_date_ye...\', undef, undef, 1451043, undef, 0, undef, \'\', ...) called at lib/Sql.pm line 150
      Sql::insert_row(\'Sql=HASH(0xe4ad7e0)\', \'artist\', \'HASH(0x6148808)\', \'id\') called at lib/MusicBrainz/Server/Data/Artist.pm line 214
      MusicBrainz::Server::Data::Artist::insert(\'MusicBrainz::Server::Data::Artist=HASH(0xbd8f788)\', \'HASH(0x121d77e0)\') called at lib/MusicBrainz/Server/Edit/Generic/Create.pm line 45
      MusicBrainz::Server::Edit::Generic::Create::insert(\'MusicBrainz::Server::Edit::Artist::Create=HASH(0xfb0fb40)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 56
      Class::MOP::Method::Wrapped::_ANON_(\'MusicBrainz::Server::Edit::Artist::Create=HASH(0xfb0fb40)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::Edit::Artist::Create::insert(\'MusicBrainz::Server::Edit::Artist::Create=HASH(0xfb0fb40)\') called at lib/MusicBrainz/Server/Data/Edit.pm line 433
      MusicBrainz::Server::Data::Edit::create(\'MusicBrainz::Server::Data::Edit=HASH(0xc2f4d50)\', \'editor_id\', 53705, \'privileges\', 185, \'name\', \'temporary test\', \'begin_date\', \'HASH(0xfb74790)\', ...) called at lib/MusicBrainz/Server/Controller.pm line 85
      MusicBrainz::Server::Controller::_ANON_() called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Try/Tiny.pm line 76
      eval

      Unknown macro: {...}

      called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try(\'CODE(0xfb74c50)\', \'Try::Tiny::Catch=REF(0xfb0ee68)\') called at lib/MusicBrainz/Server/Controller.pm line 101
      MusicBrainz::Server::Controller::_insert_edit(\'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\', \'MusicBrainz::Server::Form::Artist=HASH(0xe352d50)\', \'edit_type\', 1, \'name\', \'temporary test\', \'sort_name\', \'temporary test\', ...) called at lib/MusicBrainz/Server/Controller.pm line 136
      MusicBrainz::Server::Controller::_ANON_() called at lib/Sql.pm line 281
      Sql::_ANON_() called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Try/Tiny.pm line 76
      eval

      called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try(\'CODE(0xe6267b0)\', \'Try::Tiny::Catch=REF(0xfb74a88)\') called at lib/Sql.pm line 294
      Sql::_auto_transaction(\'CODE(0x94513a0)\', \'Sql=HASH(0xe4ad7e0)\') called at lib/Sql.pm line 299
      Sql::_run_in_transaction_one(\'CODE(0x94513a0)\', \'Sql=HASH(0xe4ad7e0)\') called at lib/Sql.pm line 313
      Sql::run_in_transaction(\'CODE(0x94513a0)\', \'Sql=HASH(0xe4ad7e0)\') called at lib/MusicBrainz/Server/Model/MB.pm line 19
      MusicBrainz::Server::Model::MB::with_transaction(\'MusicBrainz::Server::Model::MB=HASH(0xbc16198)\', \'CODE(0x94513a0)\') called at lib/MusicBrainz/Server/Controller.pm line 147
      MusicBrainz::Server::Controller::edit_action(\'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\', \'form\', \'Artist\', \'type\', 1, \'on_creation\', \'CODE(0xdb91ba0)\') called at lib/MusicBrainz/Server/Controller/Role/Create.pm line 56
      Moose::Meta::Role::_ANON_::SERIAL::88::create(\'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(\'Catalyst::Action=HASH(0xd9c8398)\', \'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1672
      eval

      Unknown macro: {...}

      called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1672
      Catalyst::execute(\'MusicBrainz::Server=HASH(0xe475440)\', \'MusicBrainz::Server::Controller::Artist\', \'Catalyst::Action=HASH(0xd9c8398)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute(\'MusicBrainz::Server=HASH(0xe475440)\', \'MusicBrainz::Server::Controller::Artist\', \'Catalyst::Action=HASH(0xd9c8398)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(\'Catalyst::Action=HASH(0xd9c8398)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Controller.pm line 158
      Catalyst::Controller::_ACTION(\'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(\'Catalyst::Action=HASH(0xd9aef90)\', \'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1672
      eval

      called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1672
      Catalyst::execute(\'MusicBrainz::Server=HASH(0xe475440)\', \'MusicBrainz::Server::Controller::Artist\', \'Catalyst::Action=HASH(0xd9aef90)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute(\'MusicBrainz::Server=HASH(0xe475440)\', \'MusicBrainz::Server::Controller::Artist\', \'Catalyst::Action=HASH(0xd9aef90)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(\'Catalyst::Action=HASH(0xd9aef90)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(\'Catalyst::Dispatcher=HASH(0x4fa9db0)\', \'forward\', \'MusicBrainz::Server=HASH(0xe475440)\', \'_ACTION\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(\'Catalyst::Dispatcher=HASH(0x4fa9db0)\', \'MusicBrainz::Server=HASH(0xe475440)\', \'_ACTION\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 362
      Catalyst::forward(\'MusicBrainz::Server=HASH(0xe475440)\', \'_ACTION\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Controller.pm line 132
      Catalyst::Controller::_DISPATCH(\'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute(\'Catalyst::Action=HASH(0xb74d0a0)\', \'MusicBrainz::Server::Controller::Artist=HASH(0xd51b1a8)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1672
      eval

      Unknown macro: {...}

      called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1672
      Catalyst::execute(\'MusicBrainz::Server=HASH(0xe475440)\', \'MusicBrainz::Server::Controller::Artist\', \'Catalyst::Action=HASH(0xb74d0a0)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute(\'MusicBrainz::Server=HASH(0xe475440)\', \'MusicBrainz::Server::Controller::Artist\', \'Catalyst::Action=HASH(0xb74d0a0)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch(\'Catalyst::Action=HASH(0xb74d0a0)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward(\'Catalyst::Dispatcher=HASH(0x4fa9db0)\', \'forward\', \'MusicBrainz::Server=HASH(0xe475440)\', \'/artist/_DISPATCH\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward(\'Catalyst::Dispatcher=HASH(0x4fa9db0)\', \'MusicBrainz::Server=HASH(0xe475440)\', \'/artist/_DISPATCH\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 362
      Catalyst::forward(\'MusicBrainz::Server=HASH(0xe475440)\', \'/artist/_DISPATCH\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 105
      Catalyst::Dispatcher::dispatch(\'Catalyst::Dispatcher=HASH(0x4fa9db0)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1618
      Catalyst::dispatch(\'MusicBrainz::Server=HASH(0xe475440)\') called at lib/MusicBrainz/Server.pm line 326
      MusicBrainz::Server::_ANON_() called at lib/MusicBrainz/Server.pm line 300
      MusicBrainz::Server::with_translations(\'MusicBrainz::Server=HASH(0xe475440)\', \'CODE(0xe6a7230)\') called at lib/MusicBrainz/Server.pm line 327
      Class::MOP::Class:::around(\'CODE(0x4366f70)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(\'MusicBrainz::Server=HASH(0xe475440)\') called at lib/MusicBrainz/Server.pm line 341
      Class::MOP::Class:::around(\'CODE(0xdacb290)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(\'MusicBrainz::Server=HASH(0xe475440)\') called at lib/MusicBrainz/Server.pm line 386
      Class::MOP::Class:::around(\'CODE(0xdade7e0)\', \'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_(\'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 35
      Class::MOP::Method::Wrapped::_ANON_(\'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::dispatch(\'MusicBrainz::Server=HASH(0xe475440)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1968
      Catalyst::_ANON_() called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Try/Tiny.pm line 76
      eval

      called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try(\'CODE(0xdb8c3b0)\', \'Try::Tiny::Catch=REF(0xe4ad4f8)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst.pm line 1974
      Catalyst::handle_request(\'MusicBrainz::Server\', \'env\', \'HASH(0xdb8c5a8)\', \'response_cb\', \'CODE(0xdb8c728)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Plugin/AutoRestart.pm line 117
      Catalyst::Plugin::AutoRestart::handle_request(\'MusicBrainz::Server\', \'env\', \'HASH(0xdb8c5a8)\', \'response_cb\', \'CODE(0xdb8c728)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Catalyst/Engine.pm line 688
      Catalyst::Engine::_ANON_(\'CODE(0xdb8c728)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Plack/Handler/FCGI.pm line 130
      Plack::Handler::FCGI::run(\'Plack::Handler::FCGI=HASH(0x21d2eb8)\', \'CODE(0x21d94d8)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Plack/Loader.pm line 84
      Plack::Loader::run(\'Plack::Loader=HASH(0x20fa290)\', \'Plack::Handler::FCGI=HASH(0x21d2eb8)\') called at /home/beta/musicbrainz-server/admin/../local/lib/perl5/Plack/Runner.pm line 267
      Plack::Runner::run(\'Plack::Runner=HASH(0x1f7c700)\') called at /home/beta/musicbrainz-server/admin/../local/bin/plackup line 10
      ';
      at lib/MusicBrainz/Server/Controller.pm line 101.
      at lib/Sql.pm line 294."

      Stack-Trace:
      line 19 MusicBrainz::Server::Model::MB
      line 147 MusicBrainz::Server::Controller
      line 56 MusicBrainz::Server::Controller::Role::Create
      line 326 MusicBrainz::Server
      line 300 MusicBrainz::Server
      line 327 MusicBrainz::Server
      line 341 MusicBrainz::Server
      line 386 MusicBrainz::Server

      Anfragedaten:
      $VAR1 = {
      'query_parameters' => {},
      'body_parameters' =>

      Unknown macro: { 'edit-artist.edit_note' => '', 'edit-artist.as_auto_editor' => '1', 'edit-artist.period.end_date.month' => '', 'edit-artist.country_id' => '', 'edit-artist.period.end_date.year' => '', 'edit-artist.period.begin_date.year' => '', 'edit-artist.gender_id' => '', 'edit-artist.ipi_codes.0' => '', 'edit-artist.period.begin_date.month' => '', 'edit-artist.period.end_date.day' => '', 'edit-artist.sort_name' => 'temporary test', 'edit-artist.type_id' => '', 'edit-artist.comment' => '', 'edit-artist.name' => 'temporary test', 'edit-artist.period.begin_date.day' => '' }

      };

      Host: pino

      Oberflächensprache: de

      URL: https://beta.musicbrainz.org/artist/create

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bitmap Michael Wiencek
                Reporter:
                nikki nikki
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Packages

                  Version Package
                  2015-06-15