Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-6284

Cancelling edits ignores DB_READ_ONLY

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2013-07-22
    • Component/s: None
    • Labels:
      None

      Description

      If you try to cancel an edit while DB_READ_ONLY is set:

      Caught exception in MusicBrainz::Server::Controller::Edit->cancel "Failed query:
      'UPDATE edit SET status = ?, close_time = NOW() WHERE id = ?'
      (9 22169771)
      DBD::Pg::st execute failed: ERROR: cannot execute UPDATE in a read-only transaction at lib/Sql.pm line 107, line 3.

      at lib/Sql.pm line 113, line 3.
      Sql::_ANON_('DBD::Pg::st execute failed: ERROR: cannot execute UPDATE in ...') called at admin/../local/lib/perl5/Try/Tiny.pm line 100
      Try::Tiny::try('CODE(0x116b24b8)', 'Try::Tiny::Catch=REF(0x116b26c8)') called at lib/Sql.pm line 114
      Sql::do('Sql=HASH(0xefa4010)', 'UPDATE edit SET status = ?, close_time = NOW() WHERE id = ?', 9, 22169771) called at lib/MusicBrainz/Server/Data/Edit.pm line 654
      MusicBrainz::Server::Data::Edit::_close('MusicBrainz::Server::Data::Edit=HASH(0xb2bde20)', 'MusicBrainz::Server::Edit::Relationship::Delete=HASH(0x11522500)', 'CODE(0x116b1de0)') called at lib/MusicBrainz/Server/Data/Edit.pm line 640
      MusicBrainz::Server::Data::Edit::reject('MusicBrainz::Server::Data::Edit=HASH(0xb2bde20)', 'MusicBrainz::Server::Edit::Relationship::Delete=HASH(0x11522500)', 9) called at lib/MusicBrainz/Server/Data/Edit.pm line 646
      MusicBrainz::Server::Data::Edit::cancel('MusicBrainz::Server::Data::Edit=HASH(0xb2bde20)', 'MusicBrainz::Server::Edit::Relationship::Delete=HASH(0x11522500)') called at lib/MusicBrainz/Server/Controller/Edit.pm line 136
      MusicBrainz::Server::Controller::Edit::_ANON_() called at lib/Sql.pm line 281
      Sql::_ANON_() called at admin/../local/lib/perl5/Try/Tiny.pm line 76
      eval

      Unknown macro: {...}

      called at admin/../local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try('CODE(0x11634b00)', 'Try::Tiny::Catch=REF(0x1159b4d0)') called at lib/Sql.pm line 294
      Sql::_auto_transaction('CODE(0x116cd678)', 'Sql=HASH(0xefa4010)') called at lib/Sql.pm line 299
      Sql::_run_in_transaction_one('CODE(0x116cd678)', 'Sql=HASH(0xefa4010)') called at lib/Sql.pm line 313
      Sql::run_in_transaction('CODE(0x116cd678)', 'Sql=HASH(0xefa4010)') called at lib/MusicBrainz/Server/Model/MB.pm line 19
      MusicBrainz::Server::Model::MB::with_transaction('MusicBrainz::Server::Model::MB=HASH(0xabec760)', 'CODE(0x116cd678)') called at lib/MusicBrainz/Server/Controller/Edit.pm line 147
      MusicBrainz::Server::Controller::Edit::cancel('MusicBrainz::Server::Controller::Edit=HASH(0xc497588)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute('Catalyst::Action=HASH(0xc817e20)', 'MusicBrainz::Server::Controller::Edit=HASH(0xc497588)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst.pm line 1672
      eval

      called at admin/../local/lib/perl5/Catalyst.pm line 1672
      Catalyst::execute('MusicBrainz::Server=HASH(0xd6c7de0)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xc817e20)') called at admin/../local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xd6c7de0)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xc817e20)') called at admin/../local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch('Catalyst::Action=HASH(0xc817e20)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst/ActionChain.pm line 38
      Catalyst::ActionChain::dispatch('Catalyst::ActionChain=HASH(0xec2cb80)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst/Controller.pm line 158
      Catalyst::Controller::_ACTION('MusicBrainz::Server::Controller::Edit=HASH(0xc497588)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute('Catalyst::Action=HASH(0x996aec0)', 'MusicBrainz::Server::Controller::Edit=HASH(0xc497588)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst.pm line 1672
      eval

      Unknown macro: {...}

      called at admin/../local/lib/perl5/Catalyst.pm line 1672
      Catalyst::execute('MusicBrainz::Server=HASH(0xd6c7de0)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0x996aec0)') called at admin/../local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xd6c7de0)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0x996aec0)') called at admin/../local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch('Catalyst::Action=HASH(0x996aec0)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x4072bc0)', 'forward', 'MusicBrainz::Server=HASH(0xd6c7de0)', '_ACTION') called at admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x4072bc0)', 'MusicBrainz::Server=HASH(0xd6c7de0)', '_ACTION') called at admin/../local/lib/perl5/Catalyst.pm line 362
      Catalyst::forward('MusicBrainz::Server=HASH(0xd6c7de0)', '_ACTION') called at admin/../local/lib/perl5/Catalyst/Controller.pm line 132
      Catalyst::Controller::_DISPATCH('MusicBrainz::Server::Controller::Edit=HASH(0xc497588)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst/Action.pm line 65
      Catalyst::Action::execute('Catalyst::Action=HASH(0xc80f970)', 'MusicBrainz::Server::Controller::Edit=HASH(0xc497588)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst.pm line 1672
      eval

      called at admin/../local/lib/perl5/Catalyst.pm line 1672
      Catalyst::execute('MusicBrainz::Server=HASH(0xd6c7de0)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xc80f970)') called at admin/../local/lib/perl5/Catalyst/Plugin/StackTrace.pm line 94
      Catalyst::Plugin::StackTrace::execute('MusicBrainz::Server=HASH(0xd6c7de0)', 'MusicBrainz::Server::Controller::Edit', 'Catalyst::Action=HASH(0xc80f970)') called at admin/../local/lib/perl5/Catalyst/Action.pm line 60
      Catalyst::Action::dispatch('Catalyst::Action=HASH(0xc80f970)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 257
      Catalyst::Dispatcher::_do_forward('Catalyst::Dispatcher=HASH(0x4072bc0)', 'forward', 'MusicBrainz::Server=HASH(0xd6c7de0)', '/edit/_DISPATCH') called at admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 237
      Catalyst::Dispatcher::forward('Catalyst::Dispatcher=HASH(0x4072bc0)', 'MusicBrainz::Server=HASH(0xd6c7de0)', '/edit/_DISPATCH') called at admin/../local/lib/perl5/Catalyst.pm line 362
      Catalyst::forward('MusicBrainz::Server=HASH(0xd6c7de0)', '/edit/_DISPATCH') called at admin/../local/lib/perl5/Catalyst/Dispatcher.pm line 105
      Catalyst::Dispatcher::dispatch('Catalyst::Dispatcher=HASH(0x4072bc0)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst.pm line 1618
      Catalyst::dispatch('MusicBrainz::Server=HASH(0xd6c7de0)') called at lib/MusicBrainz/Server.pm line 326
      MusicBrainz::Server::_ANON_() called at lib/MusicBrainz/Server.pm line 300
      MusicBrainz::Server::with_translations('MusicBrainz::Server=HASH(0xd6c7de0)', 'CODE(0xed63c28)') called at lib/MusicBrainz/Server.pm line 327
      Class::MOP::Class:::around('CODE(0x345c900)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_('MusicBrainz::Server=HASH(0xd6c7de0)') called at lib/MusicBrainz/Server.pm line 341
      Class::MOP::Class:::around('CODE(0xca516b0)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_('MusicBrainz::Server=HASH(0xd6c7de0)') called at lib/MusicBrainz/Server.pm line 386
      Class::MOP::Class:::around('CODE(0xca63990)', 'MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 162
      Class::MOP::Method::Wrapped::_ANON_('MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 35
      Class::MOP::Method::Wrapped::_ANON_('MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/x86_64-linux-gnu-thread-multi/Class/MOP/Method/Wrapped.pm line 91
      MusicBrainz::Server::dispatch('MusicBrainz::Server=HASH(0xd6c7de0)') called at admin/../local/lib/perl5/Catalyst.pm line 1968
      Catalyst::_ANON_() called at admin/../local/lib/perl5/Try/Tiny.pm line 76
      eval

      Unknown macro: {...}

      called at admin/../local/lib/perl5/Try/Tiny.pm line 67
      Try::Tiny::try('CODE(0xef8ded8)', 'Try::Tiny::Catch=REF(0xed58c78)') called at admin/../local/lib/perl5/Catalyst.pm line 1974
      Catalyst::handle_request('MusicBrainz::Server', 'env', 'HASH(0xef194b8)', 'response_cb', 'CODE(0xcaeb840)') called at admin/../local/lib/perl5/Catalyst/Plugin/AutoRestart.pm line 117
      Catalyst::Plugin::AutoRestart::handle_request('MusicBrainz::Server', 'env', 'HASH(0xef194b8)', 'response_cb', 'CODE(0xcaeb840)') called at admin/../local/lib/perl5/Catalyst/Engine.pm line 688
      Catalyst::Engine::_ANON_('CODE(0xcaeb840)') called at admin/../local/lib/perl5/Plack/Handler/FCGI.pm line 130
      Plack::Handler::FCGI::run('Plack::Handler::FCGI=HASH(0x135b688)', 'CODE(0xca738e8)') called at admin/../local/lib/perl5/Plack/Loader.pm line 84
      Plack::Loader::run('Plack::Loader=HASH(0x1283250)', 'Plack::Handler::FCGI=HASH(0x135b688)') called at admin/../local/lib/perl5/Plack/Runner.pm line 267
      Plack::Runner::run('Plack::Runner=HASH(0x1108660)') called at ./admin/../local/bin/plackup line 10
      at lib/Sql.pm line 294."

      Stack-Trace:
      line 19 MusicBrainz::Server::Model::MB
      line 147 MusicBrainz::Server::Controller::Edit
      line 326 MusicBrainz::Server
      line 300 MusicBrainz::Server
      line 327 MusicBrainz::Server
      line 341 MusicBrainz::Server
      line 386 MusicBrainz::Server

      Anfragedaten:
      $VAR1 = {
      'query_parameters' =>

      Unknown macro: { 'url' => 'https}

      ,
      'body_parameters' =>

      Unknown macro: { 'confirm.edit_note' => '' }

      };

      Host: pino

        Attachments

          Activity

            People

            • Assignee:
              ianmcorvidae Ian McEwen
              Reporter:
              nikki nikki
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Packages

                Version Package
                2013-07-22