Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-7539

series. numbering elements is not auto-edit while setting automatic is

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2014-05-26
    • None
    • Edit system
    • None

      https://musicbrainz.org/series/fd565848-7c48-47ab-b623-4dc91d1ce88d/edits
      numbering edits should have been as autoedits as setting automatic to the series was.
      without it, the series becomes instantly unordered until the edits have passed.

          [MBS-7539] series. numbering elements is not auto-edit while setting automatic is

          jesus2099 added a comment - - edited

          thanks for this fix, Bitmap, i'll make another ticket for the automod stuff. 

          jesus2099 added a comment - - edited thanks for this fix, Bitmap, i'll make another ticket for the automod stuff. 

          Michael Wiencek added a comment -

          https://bitbucket.org/metabrainz/musicbrainz-server/pull-request/960/mbs-7539-changing-the-ordering-type-is/diff

          Michael Wiencek added a comment - https://bitbucket.org/metabrainz/musicbrainz-server/pull-request/960/mbs-7539-changing-the-ordering-type-is/diff

          Michael Wiencek added a comment -

          @jesus2099 Changing the the number attributes shouldn't be autoedits, but changing the ordering type shouldn't be either, so it's definitely a bug. It was only meant to be an autoedit if the series is empty, or if an autoeditor does it. I'm not sure yet if the autoeditor bit should be changed, but I'll at least fix the main problem.

          Michael Wiencek added a comment - @jesus2099 Changing the the number attributes shouldn't be autoedits, but changing the ordering type shouldn't be either, so it's definitely a bug. It was only meant to be an autoedit if the series is empty, or if an autoeditor does it. I'm not sure yet if the autoeditor bit should be changed, but I'll at least fix the main problem.

          jesus2099 added a comment -

          Or maybe changing a series Manual→Automatic should not be autoedit, even for automods because this way, the manually set order is instantly lost and cannot be recovered.
          Or display the lost manual order visible in the edit so at least one could revert...

          maybe i say nonsense based on misknowledge.

          jesus2099 added a comment - Or maybe changing a series Manual→Automatic should not be autoedit, even for automods because this way, the manually set order is instantly lost and cannot be recovered. Or display the lost manual order visible in the edit so at least one could revert... maybe i say nonsense based on misknowledge.

            bitmap Michael Wiencek
            jesus2099 jesus2099
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2014-05-26