Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-7866

Replace ad-hoc serializing code

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None

      At least root/release/index.tt does its own ad-hoc serizalizing of entities, where only the fields important for the task at hand (here, displaying a release) are included. This is dangerous because of the client-side entity caching: Only the first version of any entity encountered is kept, all later versions are replaced by it. This may lead to mysterious bugs, or to bugs being mysteriously concealed sometimes; see https://bitbucket.org/metabrainz/musicbrainz-server/pull-request/1192/mbs-6088-serialize-edits_pending-in/diff#comment-2960060 for an example of the latter.

      This template and possibly other places that do ad-hoc serializing should be changed to use the standard serializers that are used by ws/js.

            Unassigned Unassigned
            chirlu Ulrich Klauer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:

                Version Package