Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-8621

Inconsistent result between track and release guess case after apostrophe

XMLWordPrintable

      I'm editing release 060d5875-5b8d-4d56-8975-bcc19478e866 on the beta server (b3d55ec):
      http://beta.musicbrainz.org/release/060d5875-5b8d-4d56-8975-bcc19478e866/edit
      Track 19 is titled "Tryin' to Get to You".

      If I press the "Guess Case" button at the bottom, the first "to" turns to "To" resulting in "Tryin' To Get to You".
      If I press the "Guess Case" icon (looks like "Aa") at the right of the track title, the "To" correctly turns to "to" again, resulting in "Tryin' to Get to You".

      The "Guess Case" icon works correctly, the "Guess Case" button seems to have problems with the Unicode apostrophe (U+2019).

          [MBS-8621] Inconsistent result between track and release guess case after apostrophe

          GitHub Bot added a comment -

          See code changes in pull request #1952 submitted by reosarevok.

          GitHub Bot added a comment - See code changes in pull request #1952 submitted by reosarevok .

          Nicolás Tamargo added a comment -

          Took two hours to find the bug. Turns out the guess case system saw the track "Boot ’em Up", and decided that a new single-quoted segment had started. But this was stored in a global that did not get cleared after the end of the line, so when, several tracks later, it got to "Tryin’ to Get to You", it thought "oh, great, this is finally the end of that quote! so the next word should be capitalized!". The track guesser never saw "Boot ’em Up", so the problem didn't exist there.

          Nicolás Tamargo added a comment - Took two hours to find the bug. Turns out the guess case system saw the track "Boot ’em Up", and decided that a new single-quoted segment had started. But this was stored in a global that did not get cleared after the end of the line, so when, several tracks later, it got to "Tryin’ to Get to You", it thought "oh, great, this is finally the end of that quote! so the next word should be capitalized!". The track guesser never saw "Boot ’em Up", so the problem didn't exist there.

            reosarevok Nicolás Tamargo
            yurim Yurim
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2021-03-15