Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-9111

It's still possible to leave empty edit notes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2019-10-14
    • None
    • Edit system
    • None

      It's not possible to cheat the edit note system using a simple space, but somehow editors are managing to still enter empty edit notes.
      Example of such an edit: https://musicbrainz.org/edit/41491075

      I have no idea how they're doing this. It might have been too early for me to make this ticket for this reason, but this needs to be addressed.

          [MBS-9111] It's still possible to leave empty edit notes

          Nicolás Tamargo added a comment -

          https://github.com/metabrainz/musicbrainz-server/pull/1161

          Nicolás Tamargo added a comment - https://github.com/metabrainz/musicbrainz-server/pull/1161

          Freso added a comment -

          @HibiscusKazeneko’s idea that maybe the verification accepts a string that isn’t "" before it gets sanitized and the white space removed sounds sensible. Can we check whether this is indeed the case and maybe move the whitespace stripping earlier or add whitespace checking to the verification as well?

          Freso added a comment - @ HibiscusKazeneko ’s idea that maybe the verification accepts a string that isn’t "" before it gets sanitized and the white space removed sounds sensible. Can we check whether this is indeed the case and maybe move the whitespace stripping earlier or add whitespace checking to the verification as well?

          HibiscusKazeneko added a comment -

          I made this ticket in regards to situations where edit notes are required, e.g. adding a release. Somehow editors have managed to cheat the system, it's still not clear to me exactly how.

          With regard to situations where edit notes are not required, that is a topic for another ticket. Let's not derail the issue.

          HibiscusKazeneko added a comment - I made this ticket in regards to situations where edit notes are required, e.g. adding a release. Somehow editors have managed to cheat the system, it's still not clear to me exactly how. With regard to situations where edit notes are not required, that is a topic for another ticket. Let's not derail the issue.

          Invisible Man added a comment -

          @HibiscusKazeneko You want to force this edit note for newly added releases only, right?

          There are other edit notes where it is IMHO unnecessary to add redundant info in the edit note.
          Example: What do you enter as note for a newly added Amazon- or Itunes or Homepage-URL? "Found on Amazon? iTunes? Homepage?" Or "Found thanks to Google"?

          Invisible Man added a comment - @HibiscusKazeneko You want to force this edit note for newly added releases only, right? There are other edit notes where it is IMHO unnecessary to add redundant info in the edit note. Example: What do you enter as note for a newly added Amazon- or Itunes or Homepage-URL? "Found on Amazon? iTunes? Homepage?" Or "Found thanks to Google"?

          HibiscusKazeneko added a comment -

          I just attempted to add a note to an edit like that, and it didn't work. Is this perhaps a bug with the filter that blocks editors from adding releases without notes?

          HibiscusKazeneko added a comment - I just attempted to add a note to an edit like that, and it didn't work. Is this perhaps a bug with the filter that blocks editors from adding releases without notes?

          yvanzo added a comment -

          The edit note seems to be just 5 simple spaces.

          yvanzo added a comment - The edit note seems to be just 5 simple spaces.

            reosarevok Nicolás Tamargo
            hibiscuskazeneko HibiscusKazeneko
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2019-10-14