Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-991

"Guess Case" should not convert a true apostrophe (') to a typewriter apostrophe (')

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • NGS - Beta 3
    • JavaScript
    • None

      I realize that the NGS server does not yet have Guess Case functionality, but current Guess Case will convert a true apostrophe (U+2019, ') to a typewriter apostrophe (U+0027, '). It should not do this in NGS.

          [MBS-991] "Guess Case" should not convert a true apostrophe (') to a typewriter apostrophe (')

          I just tested this and it seems to work fine? MBS-8621 is still an issue, but the apostrophe is not converted to ASCII. If I'm missing somewhere where this still happens, please reopen

          Nicolás Tamargo added a comment - I just tested this and it seems to work fine? MBS-8621 is still an issue, but the apostrophe is not converted to ASCII. If I'm missing somewhere where this still happens, please reopen

          Jim Patterson added a comment -

          There is now a clear style guideline that indicates a preference for UNICODE punctuation over ASCII https://musicbrainz.org/doc/Style/Miscellaneous#Use_of_special_characters .  However, Guess Case is still undoing track listings that have followed this advice and put in Unicode quotes rather than ASCII apostrophe's. Guess Case should leave such characters alone.

          Jim Patterson added a comment - There is now a clear style guideline that indicates a preference for UNICODE punctuation over ASCII https://musicbrainz.org/doc/Style/Miscellaneous#Use_of_special_characters .  However, Guess Case is still undoing track listings that have followed this advice and put in Unicode quotes rather than ASCII apostrophe's. Guess Case should leave such characters alone.

          ... and ellipsis too ("...")

          Aurélien Mino added a comment - ... and ellipsis too ("...")

          nikki added a comment -

          The proposal changing the relevant part of misc guideline has passed, so we should do this now. Quote marks and dashes should be left alone too.

          nikki added a comment - The proposal changing the relevant part of misc guideline has passed, so we should do this now. Quote marks and dashes should be left alone too.

          Kuno Woudt added a comment -

          Please take this to the style mailinglist, as is there's not much I can do about this as a developer. I will close this ticket for now, feel free to re-open when there is a clear decision on mb-style about what Guess Case should and shouldn't do.

          Kuno Woudt added a comment - Please take this to the style mailinglist, as is there's not much I can do about this as a developer. I will close this ticket for now, feel free to re-open when there is a clear decision on mb-style about what Guess Case should and shouldn't do.

          Alex Mauer added a comment -

          Also, I think the thread which added ellipsis to the list of taboo chars (http://thread.gmane.org/gmane.comp.audio.musicbrainz.user/8524) and specifically this post: http://article.gmane.org/gmane.comp.audio.musicbrainz.user/8816 summarize my feelings on this matter.

          There's no blanket policy against using characters outside the basic ASCII set anyway, seems silly to single out these few characters.

          Alex Mauer added a comment - Also, I think the thread which added ellipsis to the list of taboo chars ( http://thread.gmane.org/gmane.comp.audio.musicbrainz.user/8524 ) and specifically this post: http://article.gmane.org/gmane.comp.audio.musicbrainz.user/8816 summarize my feelings on this matter. There's no blanket policy against using characters outside the basic ASCII set anyway, seems silly to single out these few characters.

          Alex Mauer added a comment -

          Interesting. Perhaps that should be revisited, 5 years later and with improvements in Unicode support in OSes?

          At the least, I don't think "Guess Case" is the place to be doing this kind of data validation. If we don't want to store/convert apostrophes, then it should simply be disallowed, not half-disallowed as it is now.

          Alex Mauer added a comment - Interesting. Perhaps that should be revisited, 5 years later and with improvements in Unicode support in OSes? At the least, I don't think "Guess Case" is the place to be doing this kind of data validation. If we don't want to store/convert apostrophes, then it should simply be disallowed, not half-disallowed as it is now.

          nikki added a comment -

          nikki added a comment - that's because of http://wiki.musicbrainz.org/Miscellaneous_Guideline

            Unassigned Unassigned
            hawke Alex Mauer
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package