Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1112

Cannot save tags that were previously deleted from file

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.1
    • 1.4.2, 2.0.4
    • Tags & Metadata
    • None
    • Windows 10 64 bit

      I've noticed the last 1.x releases of Picard have this feature where if you explicitly remove a tag, it is shown with a strikethrough, I guess to indicate that the data is available but won't be saved. I'm not sure this is working as desired.

      Example:
      I added some tracks to Picard that I knew had incorrect albums tagged (it was a generic phrase like "songs"). In order to facilitate lookups, I went ahead and deleted the the album from all of them and saved them. Then I looked them up, and most of them were assigned to the correct releases. Yay!

      But now I want to save them to the newly found releases, and Picard won't save the album value anymore. It just sits there with a strikethrough. I can't find any way to tell Picard, no I really want this tag now. Is there something I'm overlooking?

          [PICARD-1112] Cannot save tags that were previously deleted from file

          Psychoadept added a comment -

          Thank you!

          Psychoadept added a comment - Thank you!

          Philipp Wolfer added a comment -

          Found the issue: After saving the files Picard still remembers the deleted tags. The correct behavior would be to forget the deletion mark after saving. I have a fix ready I will submit after PICARD-1332 has been merged

          Philipp Wolfer added a comment - Found the issue: After saving the files Picard still remembers the deleted tags. The correct behavior would be to forget the deletion mark after saving. I have a fix ready I will submit after PICARD-1332 has been merged

          Philipp Wolfer added a comment -

          I can reproduce this with 2.0.4. Also the changes in PICARD-1332 have some effect, but do not totally fix this. With the changes in the last step Picard does not show the value striked through anymore, but still does not save the data. I'll see how to fix that.

          Philipp Wolfer added a comment - I can reproduce this with 2.0.4. Also the changes in PICARD-1332 have some effect, but do not totally fix this. With the changes in the last step Picard does not show the value striked through anymore, but still does not save the data. I'll see how to fix that.

            outsidecontext Philipp Wolfer
            psychoadept Psychoadept
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.1