Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1277

Picard crashes on unknown cover art types

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: 2.0, 1.4.2
    • Fix Version/s: 2.0
    • Component/s: None
    • Labels:
      None

      Description

      See https://community.metabrainz.org/t/cant-load-an-album/388714/16?u=mineo. Picard 2 crashes with

      D: 17:31:10,904 coverart.queue_put:206: Queuing cover art image CaaCoverArtImage(url='http://coverartarchive.org/release/95f96fa2-bbcc-4e3f-9f47-9322a8f81906/20260915655.jpg', types=['front', 'raw/unedited'], is_front=True)
      Traceback (most recent call last):
      File "./picard/webservice/_init_.py", line 426, in _process_reply
      self._handle_reply(reply, request)
      File "./picard/webservice/_init_.py", line 415, in _handle_reply
      handler(reply.readAll(), reply, error)
      File "./picard/coverart/providers/caa.py", line 376, in _caa_json_downloaded
      self.next_in_queue()
      File "./picard/coverart/providers/_init_.py", line 151, in next_in_queue
      self.coverart.next_in_queue()
      File "./picard/coverart/_init_.py", line 187, in next_in_queue
      'type': coverartimage.types_as_string(),
      File "./picard/coverart/image.py", line 354, in types_as_string
      types = [translate_caa_type(type) for type in types]
      File "./picard/coverart/image.py", line 354, in <listcomp>
      types = [translate_caa_type(type) for type in types]
      File "./picard/coverart/utils.py", line 42, in translate_caa_type
      return gettext_attr(CAA_TYPES_TR[name], "cover_art_type")
      KeyError: 'raw/unedited'

      Picard 1.4 catches the exception somewhere but doesn't correctly update the album loading state.

        Attachments

          Activity

            People

            • Assignee:
              mineo Wieland Hoffmann
              Reporter:
              mineo Wieland Hoffmann
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: