Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1328

Loading OptimFROG files fails

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.0.4
    • 2.0.3
    • Tags & Metadata
    • None
    • Linux

      Picard 2.0.3 fails to load OptimFROG files on Linux (and likely also macOS):

       

      E: 23:10:49,685 /usr/lib/python3.7/site-packages/picard/util/thread.run:51: Traceback (most recent call last):

      File "/usr/lib/python3.7/site-packages/picard/util/thread.py", line 47, in run

      result = self.func()

      File "/usr/lib/python3.7/site-packages/picard/file.py", line 117, in _load_check

      return self._load(filename)

      File "/usr/lib/python3.7/site-packages/picard/formats/apev2.py", line 112, in _load

      self._info(metadata, file)

      File "/usr/lib/python3.7/site-packages/picard/formats/apev2.py", line 266, in _info

      if file.filename.lower().endswith(".ofs"):

      TypeError: endswith first arg must be bytes or a tuple of bytes, not str

       

       

          [PICARD-1328] Loading OptimFROG files fails

          Philipp Wolfer added a comment -

          This works on Windows. The reason is that mutagen.File.filename can either be a str or bytes object, see https://mutagen.readthedocs.io/en/latest/api/base.html#mutagen.fspath . And on Windows it happens to be a str object, which our code handles just fine.

          Philipp Wolfer added a comment - This works on Windows. The reason is that mutagen.File.filename can either be a str or bytes object, see https://mutagen.readthedocs.io/en/latest/api/base.html#mutagen.fspath . And on Windows it happens to be a str object, which our code handles just fine.

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.0.4