Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1847

Restructure tag compatibility options

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.4.0b1
    • None
    • User Interface
    • None

      The Tag Compatibility options page has become quite full and forces a minimal height for the entire options dialog.

      Restructure the options there. Two ideas:

      1. Introduce a tabbed view in this dialog for the separate secionts (ID3, AC3, AAC, WAVE)
      2. OR move each of those sections into a separate page (as a child of the Tags options)

        1. picard-options-tags-multi.png
          picard-options-tags-multi.png
          72 kB
        2. picard-options-tags-tabbed.png
          picard-options-tags-tabbed.png
          81 kB

          [PICARD-1847] Restructure tag compatibility options

          GitHub Bot added a comment -

          See code changes in pull request #1562 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #1562 submitted by phw .

          Philipp Wolfer added a comment -

          Yes, I agree. Also the tabbed view basically ads another hierarchy level we don't have elsewhere (except the "Classical Extras" plugin, but that has it's own reason to further structure the options). Regarding easier it doesn't matter much. I have actually coded both and the effort was about the same. I'll submit a PR.

          Philipp Wolfer added a comment - Yes, I agree. Also the tabbed view basically ads another hierarchy level we don't have elsewhere (except the "Classical Extras" plugin, but that has it's own reason to further structure the options). Regarding easier it doesn't matter much. I have actually coded both and the effort was about the same. I'll submit a PR.

          Zas added a comment -

          Not a strong preference, but "move each of those sections into a separate page" looks good to me.

           

          I think that's easier, also will scale better if we have more format-specific options.

          Zas added a comment - Not a strong preference, but "move each of those sections into a separate page" looks good to me.   I think that's easier, also will scale better if we have more format-specific options.

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.4.0b1