Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1853

Crash if tags contain null character

XMLWordPrintable

      When loading a file with a tag containing null characters and this tag is used for sorting, then Picard crashes with:

      (env) ~\devel\musicbrainz\picard [PICARD-1852-about-dialog]> python .\tagger.py
      W: 16:20:30,547 ui.mainwindow.create_actions:529: CDROM: discid library not found - Lookup CD functionality disabled
      Traceback (most recent call last):
      File ".\picard\ui\itemviews.py", line 872, in _lt_
      return self.sortkey(column) < other.sortkey(column)
      File ".\picard\ui\itemviews.py", line 877, in sortkey
      return natsort.natkey(self.text(column).lower())
      File ".\picard\util\natsort.py", line 36, in natkey
      return [int(s) if s.isdigit() else strxfrm(s)
      File ".\picard\util\natsort.py", line 36, in <listcomp>
      return [int(s) if s.isdigit() else strxfrm(s)
      ValueError: embedded null character

          [PICARD-1853] Crash if tags contain null character

          GitHub Bot added a comment -

          See code changes in pull request #1568 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #1568 submitted by phw .

          Philipp Wolfer added a comment -

          See discussion at https://community.metabrainz.org/t/various-single-files-which-seem-to-be-flacs-only-will-crash-mbz-picard/476676

          Philipp Wolfer added a comment - See discussion at https://community.metabrainz.org/t/various-single-files-which-seem-to-be-flacs-only-will-crash-mbz-picard/476676

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                2.4.0b1