Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2060

Display checkmark when no changes required for file

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Normal Normal
    • None
    • 2.5.2
    • None
    • Win10, MP3 file, ID3v2.4 only

      What I expect to see...

      When I add a file to Picard, match and save it, and then readd it to Picard I expect to see a checkmark in the right pane signifying that there are no pending changes required.

      What I see instead...

      Readding the tagged file displays a green square signifying an "excellent match" instead of the checkmark which suggests Picard thinks there's a pending change that requires saving.

      Attachment: A reference audio file where I experience this issue. This issue isn't with just this file though, it's pretty systemic across my entire library.

          [PICARD-2060] Display checkmark when no changes required for file

          Closing this, we already have PICARD-1001 for the general issue and this ticket did not reveal any new information about a concrete cause for the checkmark not showing. Most likely cover art or ID3v2.3 vs. 2.4 issues handled in separate tickets.

          Philipp Wolfer added a comment - Closing this, we already have PICARD-1001 for the general issue and this ticket did not reveal any new information about a concrete cause for the checkmark not showing. Most likely cover art or ID3v2.3 vs. 2.4 issues handled in separate tickets.

          I cannot reproduce this easily, it must depend on other factors like the exact tags your write to the file (due to scripts and plugins). Could you share your tagger script(s)?

          Also please check what cover art sources you have activated (because PICARD-1001 is one of the most common causes).

          In general there likely lurk quite a few issues like this still. If the tags we load from MB and your scripts / plugins generate cannot be fully represented by the underlying format (ID3 v2.4 in this case) the comparison on load will show a difference.

          Philipp Wolfer added a comment - I cannot reproduce this easily, it must depend on other factors like the exact tags your write to the file (due to scripts and plugins). Could you share your tagger script(s)? Also please check what cover art sources you have activated (because PICARD-1001 is one of the most common causes). In general there likely lurk quite a few issues like this still. If the tags we load from MB and your scripts / plugins generate cannot be fully represented by the underlying format (ID3 v2.4 in this case) the comparison on load will show a difference.

            Unassigned Unassigned
            navap Pavan Chander
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package