Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2362

Added __pycache__ directories make builds unreproducible

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.7
    • 2.6.4
    • Packaging & Deployment
    • None
    • linux

      Hi! When packaging 2.6.4 for Arch Linux I realized that the package is not reproducible.

      Please find attached the diffoscope output.

       

      It appears that `_pycache_` directories have leaked into the sdist tarball and should be removed/excluded.

      When removing the directories in question, the package becomes reproducible again.

        1. picard-2.6.4-diffoscope.log
          9 kB

          [PICARD-2362] Added __pycache__ directories make builds unreproducible

          Philipp Wolfer made changes -
          Status Original: In Development Branch [ 10007 ] New: Closed [ 6 ]

          Philipp Wolfer added a comment -

          Looks good now, no more _pycache_ in the latest build on https://github.com/metabrainz/picard/actions/runs/1583843606

          Thanks for reporting!

          Philipp Wolfer added a comment - Looks good now, no more _ pycache _ in the latest build on https://github.com/metabrainz/picard/actions/runs/1583843606 Thanks for reporting!
          GitHub Bot made changes -
          Resolution New: Fixed [ 1 ]
          GitHub Bot made changes -
          Status Original: Review Submitted [ 5 ] New: In Development Branch [ 10007 ]
          GitHub Bot made changes -
          Status Original: Open [ 1 ] New: Review Submitted [ 5 ]

          GitHub Bot added a comment -

          See code changes in pull request #1997 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #1997 submitted by phw .

          Philipp Wolfer added a comment -

          Good catch, that's caused by some Python code in test/data that creates the pycache when tests are being run. I'll see to get this fixed before our 2.7 release

          Philipp Wolfer added a comment - Good catch, that's caused by some Python code in test/data that creates the pycache when tests are being run. I'll see to get this fixed before our 2.7 release
          Philipp Wolfer made changes -
          Fix Version/s New: 2.7 [ 12048 ]
          Philipp Wolfer made changes -
          Assignee New: Philipp Wolfer [ outsidecontext ]
          David Runge created issue -

            outsidecontext Philipp Wolfer
            dvzrv David Runge
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Version Package
                2.7