ExportXMLWordPrintable

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Normal
    • 3.0.0rc2
    • Affects Version/s: 3.0.0rc1
    • Component/s: User Interface
    • None

      The "Make It So!" accept button (introduced in PICARD-1041, in 2017) only appears on the Options dialog; the Script Editor still uses a plain "OK".

      Some users have asked for the themed label in the Script Editor too (see https://www.reddit.com/r/MusicBrainz/comments/1w4qcs2/comment/p7trn3k/). The label is also hardcoded in a single dialog with no way to opt out for those who prefer a conventional button.

      So here are the suggested changes:

      • Add a shared add_accept_button() helper that creates a standard accept button and applies the "Make It So!" label.
      • Use the helper in the Options dialog and the Script Editor (Script Editor now shows the themed label by default).
      • Add a hidden make_it_so boolean option (default enabled, no options-page UI) to allow opting out. TBD: make it visible to users in Options?
      • Add a PICARD_MAKE_IT_SO environment override (precedence: env var > option > default), and document it in docs/EnvironmentVariables.md.
      • When disabled, the accept button keeps its native, Qt-translated label.

            Assignee:
            Zas
            Reporter:
            Zas
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                3.0.0rc2