-
Type:
Bug
-
Resolution: Fixed
-
Priority:
Normal
-
Affects Version/s: 3.0.4
-
Component/s: User Interface
-
None
When logging out of MB on the General options page and the logout fails with an error *and* the options page is closed before the logout finishes Picard crashes.
E: 06:51:13,974 webservice._handle_reply:783: Network request error for https://metabrainz.org/oauth2/revoke -> Operation timed out (QT code <NetworkError.TimeoutError: 4>, HTTP code 0) W: 06:51:13,974 util/qt._qt_message_handler:304: Qt: QIODevice::read (QNetworkReplyHttpImpl): device not open E: 06:51:13,975 oauth._on_revoke_token_finished:208: OAuth: revoking token failed: NetworkError.TimeoutError Picard terminated unexpectedly Traceback (most recent call last): File "/home/phw/devel/musicbrainz/picard/picard/webservice/__init__.py", line 872, in _process_reply self._handle_reply(reply, request) ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^ File "/home/phw/devel/musicbrainz/picard/picard/webservice/__init__.py", line 825, in _handle_reply handler(reply.readAll().data(), reply, error) ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/phw/devel/musicbrainz/picard/picard/oauth.py", line 218, in _on_revoke_token_finished callback(successful=successful, error_msg=error_msg) ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/phw/devel/musicbrainz/picard/picard/mblogin.py", line 107, in _logout_finished callback(successful, error_msg) ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^ File "/home/phw/devel/musicbrainz/picard/picard/ui/options/general.py", line 152, in on_logout_finished msg = QtWidgets.QMessageBox(self) RuntimeError: wrapped C/C++ object of type GeneralOptionsPage has been deleted
This only happens in case of an logout error (here a network timeout), as in the successful case the code checks for the dialog having been deleted already.