Uploaded image for project: 'Zapped: AcousticBrainz'
  1. Zapped: AcousticBrainz
  2. AB-442

Improve structure of dataset editor code

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None
    • None

      We need to clean up the structure of some of our javascript code:

      • Consistently use require(), instead of a mix of require and include
      • Move components into a separate file per component, as is the current best practise
      • See if we should move to typescript (now might be a good time to do it, before we add more js)
      • Set up eslint and a prettier config
      • When moving to a separate file per component, switch from 4 spaces to 2, and remove .prettierrc

          [AB-442] Improve structure of dataset editor code

          Alastair Porter added a comment -

          eslint was done by ishaanshah in https://github.com/metabrainz/acousticbrainz-server/pull/380

          Alastair Porter added a comment - eslint was done by ishaanshah in  https://github.com/metabrainz/acousticbrainz-server/pull/380

            Unassigned Unassigned
            alastairp Alastair Porter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package