Uploaded image for project: 'BookBrainz'
  1. BookBrainz
  2. BB-413

Name deduplication triggers for the entity being edited

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • Minimal usable interface
    • None
    • None
    • None

      Take the Author George Orwell on test.bb: https://test.bookbrainz.org/author/7dc4bd4f-4b1f-4fdf-bef0-b75bfb709345

      I want to swap the main and secondary alias (more known as GeorgeOrwell than Eric Arthur Blair).
      When I edit the entity and change the alias to "George Orwell", the deduplication mechanism triggers and finds an already existing Author with that name: itself !

      The deduplication mechanism should be amended to filter out the current entity's bbid.

      The affected area of code is the `checkIfExists` function: https://github.com/bookbrainz/bookbrainz-site/blob/294b3ff2bde4ff32d276aeddd4b1da33aa8553f7/src/client/entity-editor/name-section/actions.js#L131-L140
      It should have an extra optional `ignoreBBID` argument that can be used to filter out any result with a certain BBID before dispatching the action.

            mr_monkey Monkey
            mr_monkey Monkey
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                Minimal usable interface