Uploaded image for project: 'BookBrainz'
  1. BookBrainz
  2. BB-778

[beta] URLs with non‐protocol colons (“:”’s) break on characters like % and #

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Site Interface

      Links with URL encoding are not properly linked. E.g.: https://web.archive.org/web/20030828232533/http://www.theirishworld.com/pdf/2002/823%20-%2015.11.2002/15.pdf (see https://beta.bookbrainz.org/revision/162495)

      Not sure if this only applies after https?:// from BB-749 as https://bookbrainz.org/revision/162495 (note: non-beta) has the latter part of the URL working fine on its own as a non-archive.org link (which, in turn, doesn't actually work, hence why I linked archive.org in the first place) and the key%3A on https://beta.bookbrainz.org/revision/157269 seems to work too.

      Also noticed http://ir.inflibnet.ac.in:8080/ir/ViewerJS/#../bitstream/1944/1166/1/42.pdf in https://beta.bookbrainz.org/revision/157267 – in non-beta it breaks at the port, which I guess was (unintentionally?) fixed with BB-749 too, but then now breaks at the hash/pound instead. It’s working fine on https://bookbrainz.org/revision/146853 and https://beta.bookbrainz.org/revision/146853 both, so seems to be related to the parsing of the : earlier in the string.

      And "-" too: https://web.archive.org/web/20160304185705/http://sfah.dk/upload_dir/pics/Tidsskrift/Aargang-1995-1999/1997-2/AH97-2-K_DalsgaardLarsen.pdf at https://beta.bookbrainz.org/revision/149938

      I also just noticed an issue where % breaks after #, so this may be an older issue that has just been more noticeable now that colons are allowed in URLs: https://sv.wikipedia.org/wiki/Svenska_Idrottsr%C3%B6relsens_Studief%C3%B6rbund#SISU_Idrottsb%C3%B6cker on https://bookbrainz.org/revision/146698 and https://beta.bookbrainz.org/revision/146698

            mr_monkey Monkey
            freso Freso
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Version Package