• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • Python
    • None

      In the ratelimiting module, we make a "namespace" that includes "rate-limit" and the type of limiting that we're doing (ip address or auth'd user):
      https://github.com/metabrainz/brainzutils-python/blob/c8fc6058389/brainzutils/ratelimit.py#L254
      We also have a namespace function built into the cache module: https://github.com/metabrainz/brainzutils-python/blob/c8fc6058389/brainzutils/cache.py#L96
      which will automatically prepend the namespace to the key name. We could use this functionality for the "rate-limit" part of the key namespace.

          Loading...

            • Icon: Improvement Improvement
            • Resolution: Fixed
            • Icon: Normal Normal
            • None
            • Python
            • None

              In the ratelimiting module, we make a "namespace" that includes "rate-limit" and the type of limiting that we're doing (ip address or auth'd user):
              https://github.com/metabrainz/brainzutils-python/blob/c8fc6058389/brainzutils/ratelimit.py#L254
              We also have a namespace function built into the cache module: https://github.com/metabrainz/brainzutils-python/blob/c8fc6058389/brainzutils/cache.py#L96
              which will automatically prepend the namespace to the key name. We could use this functionality for the "rate-limit" part of the key namespace.

                    Unassigned Unassigned
                    alastairp Alastair Porter
                    Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                      Created:
                      Updated:

                        Version Package

                          Unassigned Unassigned
                          alastairp Alastair Porter
                          Votes:
                          0 Vote for this issue
                          Watchers:
                          1 Start watching this issue

                            Created:
                            Updated:

                              Version Package