Uploaded image for project: 'CritiqueBrainz'
  1. CritiqueBrainz
  2. CB-356

Handle reviews with deleted entities in musicbrainz-db

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v-2020-10-26.0
    • Component/s: Frontend
    • Labels:
      None

      Description

      What?

      Currently, the deployed code on beta.critiquebrainz.org include merges from the following PRs:

      https://github.com/metabrainz/brainzutils-python/pull/29

      https://github.com/metabrainz/critiquebrainz/pull/262

      The changes in CB also include using brainzutils.musicbrainz_db.utils.get_entities_by_gid. In CB, the implemented function from critiquebrainz.musicbrainz_db.utils.get_entities_by_gid handles the case of returning unknown entities in case there is a review for a release_group/event/place that was deleted (in future) from the musicbrainz database.
      This needs to be fixed.

        Attachments

          Activity

            People

            Assignee:
            spellew Shamroy Pellew
            Reporter:
            ferbncode Suyash Garg
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Packages

                Version Package
                v-2020-10-26.0