Uploaded image for project: 'CritiqueBrainz'
  1. CritiqueBrainz
  2. CB-376

Breaking change in API (created => published_on)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • v-2020-10-09.0
    • None
    • Web service
    • None

      CB-352 changed the API to accept published_on instead of created as a sort method. While this probably has a point, nothing was done to ensure backwards compatibility. This broke MusicBrainz's usage of the API (MBS-11077) and might have affected other API consumers. On critiquebrainz/ws/review/views.py created should be accepted, but mapped to published_on (in the same way rating is mapped to popularity), in case someone else still is using sort=created and getting back errors like MusicBrainz was.

      While at it, the docs should be updated (last I checked they still showed created as the correct parameter)

            kartik1712 amCap1712
            reosarevok Nicolás Tamargo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                v-2020-10-09.0