Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-1058

Change playlist JSPF fields 'artist_mbid' and to 'artist_identifier' to 'artist_identifiers'

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None
    • None

      This concerns a custom JSPF extension that we use for our playlist format.
      The `artist_mbid` field contains a list of full URIs (i.e. "https://musicbrainz.org/artist/4c0d9acf-a8a1-4765-9c56-05f92f68c048") instead of the expected list of MBIDs that the name suggests.

      We initially named the field artist_identifier (which would also be semantically incorrect considering we return a list, not a single item) which was then changed to artist_mbids in the Troi playlist generator (see https://wiki.musicbrainz.org/jspf?diff=75246&oldid=74988).

      The result is confusion:

      • Troi playlists are created with `artist_mbids` while the API returns with the field named `artist_identifier`
      • Both of those names are semantically incorrect
      • currently the front-end has to support both fields, and displays malformed links (i.e. "https://musicbrainz.org/artist/https://musicbrainz.org/artist/4c0d9acf-a8a1-4765-9c56-05f92f68c048") when receiving full URIs instead of the MBIDs it expects.

      The solution to all that is to name the field `artist_identifiers` everywhere, that is in the API, in Troi, in the front-end code that manipulates playlists and in the docs.

            alastairp Alastair Porter
            mr_monkey Monkey
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package