Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-1164

BrainzPlayer controls update too often

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None

      I presume due to bad handling of the props we pass down to the BrainzPlayer UI, whenever the progressbar update, so do certain other elements of the player. In particular all the icons (FontAwesome icons) get regenerated (they have a random string in their class name) causing too many layout refreshes.
      This probably slows down the UI too, since the refresh happens a little over once per second.

      We should isolate or memoize or whatever it is youngsters do these days.

            Unassigned Unassigned
            mr_monkey Monkey
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package