Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-12

MAX_ITEMS_PER_GET is not used as an upper bound of the number of items per get request

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • API
    • None

      With https://github.com/metabrainz/listenbrainz-server/blob/master/webserver/views/api.py#L114 (note the call is to max, not min), if count is larger than MAX_ITEMS_PER_GET, MAX_ITEMS_PER_GET is not the upper limit. Supplying count doesn't work yet, but it's possible to see the result of this bug at a different place: if you request the listens of a user, you get MAX_ITEMS_PER_GET listens, not DEFAULT_ITEMS_PER_GET.

            mineo Wieland Hoffmann
            mineo Wieland Hoffmann
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package