Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-1327

Listening now page shows duplicate tags

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None
    • None

        [LB-1327] Listening now page shows duplicate tags

        Monkey added a comment - - edited

        Thanks for the feedback !
        I've created LB-1336 and LB-1337 (finally got to the leet number)
        Feel free to add more comments on 1337 if you find more !

        Monkey added a comment - - edited Thanks for the feedback ! I've created LB-1336 and LB-1337 (finally got to the leet number) Feel free to add more comments on 1337 if you find more !

        chaban added a comment -

        The duplication issue seems gone, noticed no side-effects so far.
        Instead I noticed another bug or rather an UI issue. The release tags actually refer to the release group.

        One thing that could be improved is when withdrawing a vote it removes the tag entirely currently (when it's shown as upvoted on load). It might make more sense to change to the "neutral" grey instead.
        And when I have already downvoted a tag before loading "listening now" it's not shown in red but the "neutral" grey.

        Also, sometimes when reloading the page I see (prod and test):

        TypeError
        Failed to fetch
        

        API rate limit? (503 in console for ws requests when it happens)

        chaban added a comment - The duplication issue seems gone, noticed no side-effects so far. Instead I noticed another bug or rather an UI issue. The release tags actually refer to the release group. One thing that could be improved is when withdrawing a vote it removes the tag entirely currently (when it's shown as upvoted on load). It might make more sense to change to the "neutral" grey instead. And when I have already downvoted a tag before loading "listening now" it's not shown in red but the "neutral" grey. Also, sometimes when reloading the page I see (prod and test): TypeError Failed to fetch API rate limit? (503 in console for ws requests when it happens)

        Monkey added a comment - - edited

        chaban I tested after deploying that PR to https://test.listenbrainz.org/listening-now/ and the duplication issue appears fixed for me. Could you please also try it out ? Maybe also with the same examples you used previously to ensure I fixed the issue you pointed out (there could potentially be multiple issues at play).

        note: The page on test.LB won't update automatically when a listen comes in I'm afraid; you will need to refresh the page for the current listening-now listen to show

        Monkey added a comment - - edited chaban I tested after deploying that PR to https://test.listenbrainz.org/listening-now/ and the duplication issue appears fixed for me. Could you please also try it out ? Maybe also with the same examples you used previously to ensure I fixed the issue you pointed out (there could potentially be multiple issues at play). note: The page on test.LB won't update automatically when a listen comes in I'm afraid; you will need to refresh the page for the current listening-now listen to show

        Monkey added a comment -

        I've opened a PR to fix the duplicated user's tags issue before I forget
        Will test on the test server when I can.

        Bug aside, there are still some UI questions to resolve to allow tagging multiple artists.

        Monkey added a comment - I've opened a PR to fix the duplicated user's tags issue before I forget Will test on the test server when I can. Bug aside, there are still some UI questions to resolve to allow tagging multiple artists.

        GitHub Bot added a comment -

        See code changes in pull request #2560 submitted by MonkeyDo.

        GitHub Bot added a comment - See code changes in pull request #2560 submitted by MonkeyDo .

        chaban added a comment -

        There is definitely a problem with voted tags. When I withdrew my votes from the artist on MB while "listening now" was active and then did the same there things became very weird:

        chaban added a comment - There is definitely a problem with voted tags. When I withdrew my votes from the artist on MB while "listening now" was active and then did the same there things became very weird:

        chaban added a comment -

        I suspected as much but why is it displayed three times? Option 2 might have problems scaling when there are many artists and for what's it worth, currently when adding a new tag through "listening now" it seems to be added only to the first artist.

        Just now I've experimented on a recording with 6 artists:

        https://lonealphamusic.bandcamp.com/album/virtual-paradise

        The main artist had a set of genres which I upvoted, then I went to duplicate the same genres to the other artists and added an additional random genre to each. Yet they are only shown two times. For the next track (Seasons) the second artist doesn't have any genres as of now yet I see the same duplicated tags. Weird. Could it rather have something to do with upvoted tags?

        chaban added a comment - I suspected as much but why is it displayed three times? Option 2 might have problems scaling when there are many artists and for what's it worth, currently when adding a new tag through "listening now" it seems to be added only to the first artist. Just now I've experimented on a recording with 6 artists: https://lonealphamusic.bandcamp.com/album/virtual-paradise The main artist had a set of genres which I upvoted, then I went to duplicate the same genres to the other artists and added an additional random genre to each. Yet they are only shown two times. For the next track (Seasons) the second artist doesn't have any genres as of now yet I see the same duplicated tags. Weird. Could it rather have something to do with upvoted tags?

        Monkey added a comment -

        Ah yes, thanks chaban. One objection I had but did not express about the idea of "a line of tags for each artist" is that it starts to break down the more featuring artists there are. Imagine with 15 featuring artists !

        Monkey added a comment - Ah yes, thanks chaban. One objection I had but did not express about the idea of "a line of tags for each artist" is that it starts to break down the more featuring artists there are. Imagine with 15 featuring artists !

        Monkey added a comment -

        Thanks for the report !

        I think this is caused by us fetching and displaying tags for both artists at the same time (both are tagged "hip hop", hence the duplicate).

        More generally, this touches on how to display tags clearly to the user and always making it clear which entity a user is tagging.

        Clear options I see:

        • Only show tags for the main artist
        • Show tags for each artist separately in a separate component/line, with the artist name repeated above.

        I'm not a fan of either of those solutions; if people have opinions please share them

        Monkey added a comment - Thanks for the report ! I think this is caused by us fetching and displaying tags for both artists at the same time (both are tagged "hip hop", hence the duplicate). More generally, this touches on how to display tags clearly to the user and always making it clear which entity a user is tagging. Clear options I see: Only show tags for the main artist Show tags for each artist separately in a separate component/line, with the artist name repeated above. I'm not a fan of either of those solutions; if people have opinions please share them

          mr_monkey Monkey
          chaban chaban
          Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

            Created:
            Updated:
            Resolved:

              Version Package