• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None
    • None

      We have a nice way to add individual song listens to ListenBrainz, but for people who listen to entire albums this isn't a very time-effective method.

      The UI for the manual addition function would not need much changed - a 'Add album' button next to the 'Add song' button, and 'song' swapped for 'album' in the search box placeholder text.

        1. android-dropdown-01.png
          android-dropdown-01.png
          23 kB
        2. android-dropdown-02.png
          android-dropdown-02.png
          124 kB
        3. image-2023-01-07-10-19-37-997.png
          image-2023-01-07-10-19-37-997.png
          17 kB
        4. image-2023-01-27-08-48-09-088.png
          image-2023-01-27-08-48-09-088.png
          92 kB
        5. screenshot-1.png
          screenshot-1.png
          6 kB
        6. timestamp test.png
          timestamp test.png
          14 kB

          [LB-1401] Manually add album listens

          Aerozol added a comment -

          I'm getting deja vu that I've mentioned this before, and there was nothing that could be done/it was native OS or browser behaviour, so I wont make a new ticket (yet) - on my mobile (Android S9+) the manual submitter/search drop down looks like this:

          Which makes it look like there were no results (but when you tap the little down arrow you get the full list/can see the results).

          On that note, I can see why we would hide some detail in the mobile search results, but maybe we are hiding too much? This isn't very useful, I ended up browsing via MB and pasting in the URL instead (cool that we can do that though!):

          Aerozol added a comment - I'm getting deja vu that I've mentioned this before, and there was nothing that could be done/it was native OS or browser behaviour, so I wont make a new ticket (yet) - on my mobile (Android S9+) the manual submitter/search drop down looks like this: Which makes it look like there were no results (but when you tap the little down arrow you get the full list/can see the results). On that note, I can see why we would hide some detail in the mobile search results, but maybe we are hiding too much? This isn't very useful, I ended up browsing via MB and pasting in the URL instead (cool that we can do that though!):

          Aerozol added a comment -

          It's not working at all for me now (submitting an album listen)

          So I couldn't check if you addressed my long-winded comment - that submitting listens 'Now' was defaulting to 'Finishes at' even when the checkbox next door, so to speak, defaults to 'Starts at', which is going to throw people.

          Aerozol added a comment - It's not working at all for me now (submitting an album listen) So I couldn't check if you addressed my long-winded comment - that submitting listens 'Now' was defaulting to 'Finishes at' even when the checkbox next door, so to speak, defaults to 'Starts at', which is going to throw people.

          Monkey added a comment -

          I set the date-time picker to use the browser's locale, so that should be simpler
          PR is deployed on test.LB if you want to check it yourself

           

          Monkey added a comment - I set the date-time picker to use the browser's locale, so that should be simpler PR is deployed on test.LB if you want to check it yourself  

          David Kellner added a comment -

          Oh, that was just an observation I made when I inspected the listens which were submitted by this feature. The tracks had a tracknumber property, but it had a null value.
          Now that I actually looked at the code, I guess it failed because the track had an alphanumeric track number.
          Given your question on #metabrainz you have probably solved that issue already

          Don't worry too much about the 24 hour clock, I think I have learned to use the existing time picker

          David Kellner added a comment - Oh, that was just an observation I made when I inspected the listens which were submitted by this feature. The tracks had a tracknumber property, but it had a null value. Now that I actually looked at the code , I guess it failed because the track had an alphanumeric track number. Given your question on #metabrainz you have probably solved that issue already Don't worry too much about the 24 hour clock, I think I have learned to use the existing time picker

          Monkey added a comment - - edited

          Thanks for the bug reports !
          Hadn't seen these messages...

          Regarding the 24h clock, I'm afraid that's not available in the component we use (https://github.com/wojtekmaj/react-datetime-picker) but I could consider replacing it.
          Found out how to fix that !

          The timestamp preview is a good idea, but requires significant refactoring as currently these tracks display components are independant from the submission logic, and as a consequence do not currently have access to the selected timestamp.

          The range select stuff for checkboxes sounds cool, I'll see if there is some code I can copy take inspiration from.

          I'm not sure what you mean by "tracknumber": null is not populated...

          Which bit of code are you referring to?

          Monkey added a comment - - edited Thanks for the bug reports ! Hadn't seen these messages... Regarding the 24h clock, I'm afraid that's not available in the component we use ( https://github.com/wojtekmaj/react-datetime-picker ) but I could consider replacing it. Found out how to fix that ! The timestamp preview is a good idea, but requires significant refactoring as currently these tracks display components are independant from the submission logic, and as a consequence do not currently have access to the selected timestamp. The range select stuff for checkboxes sounds cool, I'll see if there is some code I can copy take inspiration from. I'm not sure what you mean by "tracknumber": null is not populated... Which bit of code are you referring to?

          David Kellner added a comment - - edited

          In addition to what aerozol already mentioned, I have a few small suggestions:

          • Having range select support to the checkboxes would be very convenient (as MB does it almost everywhere when I hold the shift key).
          • Show the MusicBrainz tracknumber instead of the numeric position, seeing A1, ..., B1 etc. makes it easier to select all tracks for one side of an analog medium.
          • Maybe preview the timestamps of the listens that will be submitted as another column? That would help to avoid confusion what the Now pill does and may be a good sanity check in a few other cases as well.
          • Is it possible to have a 24 hour clock instead of am/pm? I tried to set the hours to 11(am) shortly after noon when the selector defaulted to pm and automatically changed everything I tried to enter to 12pm automatically (probably because the time would have been in the future). I had to change pm to am before I could enter the time I wanted.

          And a few small bugs:

          • "tracknumber": null is not populated, MB should always have this data.
          • The submitted listens contain a field track_metadata.release_mbid instead of track_metadata.additional_info.release_mbid, which is probably the reason why the production website shows the wrong cover and links the wrong album for some of the listens I submitted this way. (Beta shows the correct cover and links the correct album page!?)

          David Kellner added a comment - - edited In addition to what aerozol already mentioned, I have a few small suggestions: Having range select support to the checkboxes would be very convenient (as MB does it almost everywhere when I hold the shift key). Show the MusicBrainz tracknumber instead of the numeric position, seeing A1, ..., B1 etc. makes it easier to select all tracks for one side of an analog medium. Maybe preview the timestamps of the listens that will be submitted as another column? That would help to avoid confusion what the Now pill does and may be a good sanity check in a few other cases as well. Is it possible to have a 24 hour clock instead of am/pm? I tried to set the hours to 11(am) shortly after noon when the selector defaulted to pm and automatically changed everything I tried to enter to 12pm automatically (probably because the time would have been in the future). I had to change pm to am before I could enter the time I wanted. And a few small bugs: "tracknumber": null is not populated, MB should always have this data. The submitted listens contain a field track_metadata.release_mbid instead of track_metadata.additional_info.release_mbid , which is probably the reason why the production website shows the wrong cover and links the wrong album for some of the listens I submitted this way. (Beta shows the correct cover and links the correct album page!?)

          Aerozol added a comment - - edited

          Amazing!!

          One thing is unclear to me in the UI - when you set the album to submit from 'now', it's the same as having the toggle at 'Finishes at'. I'm not against this being the default, but because the greyed out toggle on the right is stuck at 'Starts at', and there's no indication it will do otherwise, I don't think the user will expect it. I don't know if it's a big headache to change, but possible the toggle could be moved above the two options, and apply to the 'now' button as well?

          Plus an error when submitting listens for https://beta.musicbrainz.org/release/e1dd0af1-78c0-4afb-8544-cb05edaaa204, regardless of what time options are picked (release has track times, except for one track):

          Aerozol added a comment - - edited Amazing!! One thing is unclear to me in the UI - when you set the album to submit from 'now', it's the same as having the toggle at 'Finishes at'. I'm not against this being the default, but because the greyed out toggle on the right is stuck at 'Starts at', and there's no indication it will do otherwise, I don't think the user will expect it. I don't know if it's a big headache to change, but possible the toggle could be moved above the two options, and apply to the 'now' button as well? Plus an error when submitting listens for https://beta.musicbrainz.org/release/e1dd0af1-78c0-4afb-8544-cb05edaaa204 , regardless of what time options are picked (release has track times, except for one track):

          Monkey added a comment -

          I have just deployed this new feature on beta.listenbrainz.org , please test to your heart's content and let me know if anything is unexpected, broken, or is not very clear to you.

          Monkey added a comment - I have just deployed this new feature on beta.listenbrainz.org , please test to your heart's content and let me know if anything is unexpected, broken, or is not very clear to you.

          Monkey added a comment - - edited

          boysmithers Yes indeed!
          This album submission tool will allow you to select a specific release, either by MBID or by text search, and the release MBID will be submitted as part of the listen.

          Please also see LB-1531 and add a comment to request any other additional fields you want to set in the listen payload.

          Monkey added a comment - - edited boysmithers Yes indeed! This album submission tool will allow you to select a specific release, either by MBID or by text search, and the release MBID will be submitted as part of the listen. Please also see LB-1531 and add a comment to request any other additional fields you want to set in the listen payload.

          boysmithers added a comment -

          Hello, just a question/suggestion/request - is there any way that this would specify the actual album that was listened to, in a way that the "add individual listen" doesn't do? (it only specifies the recording)

          Examples of things which use the album MBID:

          Picard plugin
          https://gitlab.com/Flaky/picard-submit-to-listenbrainz

          Poweramp plugin
          https://github.com/StratusFearMe21/listenbrainz-poweramp

          Thanks!

           

          boysmithers added a comment - Hello, just a question/suggestion/request - is there any way that this would specify the actual album that was listened to, in a way that the "add individual listen" doesn't do? (it only specifies the recording) Examples of things which use the album MBID: Picard plugin https://gitlab.com/Flaky/picard-submit-to-listenbrainz Poweramp plugin https://github.com/StratusFearMe21/listenbrainz-poweramp Thanks!  

            mr_monkey Monkey
            aerozol Aerozol
            Votes:
            7 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:

                Version Package