Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-516

Rewrite the last.fm importer retry logic to be iterative.

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None

      Currently the retry logic in the APIService file for submit-listens recursively calls the same function if there's a rate limit error or something similar.

       

      This is risky as it can lead to heap overflows in the real world. We should change this logic to be iterative instead.

          Loading...
          Uploaded image for project: 'ListenBrainz'
          1. ListenBrainz
          2. LB-516

          Rewrite the last.fm importer retry logic to be iterative.

            • Icon: Improvement Improvement
            • Resolution: Fixed
            • Icon: Normal Normal
            • None
            • None

              Currently the retry logic in the APIService file for submit-listens recursively calls the same function if there's a rate limit error or something similar.

               

              This is risky as it can lead to heap overflows in the real world. We should change this logic to be iterative instead.

                    cyclone Jason Dao
                    iliekcomputers Param Singh
                    Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                      Created:
                      Updated:
                      Resolved:

                        Version Package

                          cyclone Jason Dao
                          iliekcomputers Param Singh
                          Votes:
                          0 Vote for this issue
                          Watchers:
                          3 Start watching this issue

                            Created:
                            Updated:
                            Resolved:

                              Version Package