Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-767

stop 'sanitising' docker compose container names

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None

      We have the following comment/transform scattered throughout the codebase:

      # Project name is sanitized by Compose, so we need to do the same thing.
      # See https://github.com/docker/compose/issues/2119.
      INT_COMPOSE_PROJECT_NAME=$(echo $INT_COMPOSE_PROJECT_NAME_ORIGINAL | awk '{print tolower($0)}' | sed 's/[^a-z0-9]*//g')

      However, docker-compose no longer does this. It happily leaves a - or a _ in the project prefix of a container name. 

      We should remove all of these comments and transformations from the scripts that currently use them.

            kartik1712 amCap1712
            alastairp Alastair Porter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package