Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-849

Require users to have a confirmed email before creating an LB account

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None
    • None

      We find that sometimes we need to email users from ListenBrainz. This could be to inform them that their spotify import failed, or because we think that they might be submitting untrustworthy data to LB.

      We should double-check if users can create an LB account without first verifying their email address on musicbrainz. If they can, we should work out a way to require them to first verify their email address.

      We need a way to address existing users who may have snuck around this limitation until now.

          [LB-849] Require users to have a confirmed email before creating an LB account

          GitHub Bot added a comment -

          See code changes in pull request #1422 submitted by amCap1712.

          GitHub Bot added a comment - See code changes in pull request #1422 submitted by amCap1712 .

          Robert Kaye added a comment -

          Yes, we should. Let's do this:

          1. Upon attempting to create an account for a user, we should check to see if the user has an email address. If not, stop the process and direct the user to the MB page to add their email address.
          2. In the GDPR / ToS screen we have now, we should put a note that says: "In order to combat spammers and to be able to contact our users in case something goes wrong with the listen submission process, we now require an email address when creating a ListenBrainz account."
          3. We should implement the no email address check now and block it with the config option of SUBMIT_LISTENS_WITHOUT_USER_EMAIL = True. On nov 1, we can flip the switch to False and deploy easily.
          4. If a user logs in and we have no email address on their account, we should show a banner on LB that says "You have not provided an email address. Please provide a email address before 1. November 2021, or we will stop recording your submitted listens." The banner should include a link to the form where the user can set their email address. LB-874 is a follow up ticket to flip the config switch on Nov 1.

          Robert Kaye added a comment - Yes, we should. Let's do this: Upon attempting to create an account for a user, we should check to see if the user has an email address. If not, stop the process and direct the user to the MB page to add their email address. In the GDPR / ToS screen we have now, we should put a note that says: "In order to combat spammers and to be able to contact our users in case something goes wrong with the listen submission process, we now require an email address when creating a ListenBrainz account." We should implement the no email address check now and block it with the config option of SUBMIT_LISTENS_WITHOUT_USER_EMAIL = True. On nov 1, we can flip the switch to False and deploy easily. If a user logs in and we have no email address on their account, we should show a banner on LB that says "You have not provided an email address. Please provide a email address before 1. November 2021, or we will stop recording your submitted listens." The banner should include a link to the form where the user can set their email address. LB-874 is a follow up ticket to flip the config switch on Nov 1.

            kartik1712 amCap1712
            kartik1712 amCap1712
            Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package