Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-905

Fix full dumps code

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Invalid
    • Icon: Normal Normal
    • None
    • data dumps
    • None

      The code to create a full dump is buggy.

      The -last-dump-id defaults to True and -dump-id defaults to None. Hence, both of the if conditions are executed and hence the dump_id set by the last_dump_id check is overridden by the next if. Due to this accidental combinations, dumps work correctly.

      My understanding is that --last-dump-id only needs to be used when the previous full dump didn't complete correctly. It should default to False and the if checks should be fixed so that dumps continue working.

            kartik1712 amCap1712
            kartik1712 amCap1712
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package