Uploaded image for project: 'MusicBrainz Batch Edits'
  1. MusicBrainz Batch Edits
  2. MBBE-49

Migrate RecMusic URLs to Tower Records Music URLs

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Normal Normal
    • URL

      See MBBE-48. Old RecMusic URLs now redirect to their counterparts on the new Tower Records Music site. Much of the original URL format is still intact, so it should be simple to use machine learning to generate corresponding Tower Records Music links for old RecMusic links.
      Release example: https://recmusic.jp/album/?id=1010526534 redirects to https://music.tower.jp/album/detail/1010526534
      Artist example: https://recmusic.jp/artist/?id=2000017248 redirects to https://music.tower.jp/artist/detail/2000017248

      Of course, the new links should have 2021-10-01 as a begin link.

          [MBBE-49] Migrate RecMusic URLs to Tower Records Music URLs

          Only problem is that unless it's announced somewhere, it's perfectly possible that users won't even notice the 5 or 6 edits at all  

          Nicolás Tamargo added a comment - Only problem is that unless it's announced somewhere, it's perfectly possible that users won't even notice the 5 or 6 edits at all  

          derat added a comment - - edited

          The Bot Code of Conduct contains rules that seem to be intended to limit the damage caused by buggy bots (1000 edits per day, 2000 open edits, human contact info in profiles, requirement to respond to edit notes in reasonable time).

          Maybe it'd be good to have an additional rule like "when starting a new task, limit your bot to X edits and wait for Y hours/days for people to catch issues before creating hundreds of edits." (For me, X is 5 or 6 and Y is a few hours, but I'm happy to change those numbers if it'd be helpful.)

          I'd probably also add something like "make sure that you're able to cancel your bot's edits before they're applied if/when someone finds a problem." 

          derat added a comment - - edited The Bot Code of Conduct contains rules that seem to be intended to limit the damage caused by buggy bots (1000 edits per day, 2000 open edits, human contact info in profiles, requirement to respond to edit notes in reasonable time). Maybe it'd be good to have an additional rule like "when starting a new task, limit your bot to X edits and wait for Y hours/days for people to catch issues before creating hundreds of edits." (For me, X is 5 or 6 and Y is a few hours, but I'm happy to change those numbers if it'd be helpful.) I'd probably also add something like "make sure that you're able to cancel your bot's edits before they're applied if/when someone finds a problem." 

          jesus2099 added a comment - - edited

          Yes yes they are no mistakes, here.
          But the nature of bots makes massive edits perform in a short time.
          Maybe a validation workflow should exist before bot waves of edits?
          Just an ok comment by staff in the tickets.
          But it's maybe overkill, nevermind my concerns. 😉

          jesus2099 added a comment - - edited Yes yes they are no mistakes, here. But the nature of bots makes massive edits perform in a short time. Maybe a validation workflow should exist before bot waves of edits? Just an ok comment by staff in the tickets. But it's maybe overkill, nevermind my concerns. 😉

          Seems sensible enough to me.

          Nicolás Tamargo added a comment - Seems sensible enough to me.

          derat added a comment -

          This seems non-controversial, unless I'm missing something: the old URLs are broken now and the new URLs work. Isn't marking the old ones as ended and adding the new ones the normal thing to do here, regardless of whether it's done by a human or by a bot?

          derat added a comment - This seems non-controversial, unless I'm missing something: the old URLs are broken now and the new URLs work. Isn't marking the old ones as ended and adding the new ones the normal thing to do here, regardless of whether it's done by a human or by a bot?

          jesus2099 added a comment - - edited

          We should not wait for some staff review or some kind of official approval, before letting the bot change them?

          I'm ok with voting the edits to say I validate but I'm not staff and also edits are applied fast when 3 voters vote yes.

          jesus2099 added a comment - - edited We should not wait for some staff review or some kind of official approval, before letting the bot change them? I'm ok with voting the edits to say I validate but I'm not staff and also edits are applied fast when 3 voters vote yes.

          derat added a comment -

          The rest of the edits have been created: https://musicbrainz.org/user/derat_bot/edits/open

          After they're applied, I'll close this bug.

          derat added a comment - The rest of the edits have been created: https://musicbrainz.org/user/derat_bot/edits/open After they're applied, I'll close this bug.

          derat added a comment -

          Here are votable edits for the first 4 music.tower.jp URLs:

          (I skipped the first 2 recmusic.jp URLs as described in the previous comment.)

          derat added a comment - Here are votable edits for the first 4 music.tower.jp URLs: https://musicbrainz.org/edit/98030806 https://musicbrainz.org/edit/98030808 https://musicbrainz.org/edit/98030810 https://musicbrainz.org/edit/98030818 (I skipped the first 2 recmusic.jp URLs as described in the previous comment.)

          derat added a comment -

          Of the 391 recmusic.jp URLs that I see in the 20230315-002054 dump, all but two of them look like they're still working after rewriting to music.tower.jp as described above. Here are the two that don't work after rewriting:

          Just to mention it, the new Tower Records site seems a bit janky. It gives a 404 status code and a "データが見つかりませんでした。" message for some URLs (e.g. https://music.tower.jp/artist/detail/2001445271), but if you give it a completely bogus URL like https://music.tower.jp/artist/detail/blah, it returns a 200 status and a different "お探しのページが見つかりません" error page. I ended up grepping for "p-content__body" instead since that class name seems to be used in valid artist and album pages but not in either error page.

          derat added a comment - Of the 391 recmusic.jp URLs that I see in the 20230315-002054 dump, all but two of them look like they're still working after rewriting to music.tower.jp as described above. Here are the two that don't work after rewriting: https://recmusic.jp/artist/?id=2001445271 ( https://music.tower.jp/artist/detail/2001445271 ) https://recmusic.jp/album/?id=1016070930 ( https://music.tower.jp/album/detail/1016070930 ) Just to mention it, the new Tower Records site seems a bit janky. It gives a 404 status code and a "データが見つかりませんでした。" message for some URLs (e.g. https://music.tower.jp/artist/detail/2001445271 ), but if you give it a completely bogus URL like https://music.tower.jp/artist/detail/blah , it returns a 200 status and a different "お探しのページが見つかりません" error page. I ended up grepping for "p-content__body" instead since that class name seems to be used in valid artist and album pages but not in either error page.

            derat derat
            hibiscuskazeneko HibiscusKazeneko
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package