Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-10475

Edits trying to remove mediums that were canceled make it look like the wrong (good) medium is gonna be removed

XMLWordPrintable

      From IRC

      <chaban> Another case where edit preview is confusing: https://musicbrainz.org/edit/65138577 It isn't going to remove the only remining medium, is it? 
      <chaban> Before the medium add was canceled it displayed CD2 will be removed.
      <reosarevok> Prooobably not?
      <reosarevok> I wish I could say with 100% certainty that it won't remove the other medium :p
      <reosarevok> Wanna set a test in test.musicbrainz.org and see? :p
      <chaban> OMG it's gone: https://test.musicbrainz.org/release/89efb0fd-806a-4802-b8d4-d219652702cc
      <reosarevok> Are you sure the removal was pointing to the other medium, and not to this one (and the other got cancelled)?
      * reosarevok checks the code for remove medium
      <reosarevok> Hmm. The data includes the medium id
      <reosarevok> So if we're not checking by that ID, we clearly should be
      

      ...

      <chaban> reosarevok: Unsuccessfully tried to reproduce with a fresh release: https://test.musicbrainz.org/release/a4f73d09-ba57-48f7-9cc7-b26164357ec8/edits 
      <chaban> Looks like only old releases when medium adds didn't exist yet are affected.
      <reosarevok> Huh
      <reosarevok> That's... weird, but I guess there's a reason. Still, please document :)
      <chaban> Can no longer reproduce with old release add (type 216): https://test.musicbrainz.org/release/6b2d1604-b965-4068-b071-2a4007cbefb4/edits 
      <chaban> This time I tried to make the exact same steps (except dupe edits)
      <chaban> (First time I rushed because there were already 2 yes-votes)
      <chaban> So, does this mean edit data and display was misleading again (MBS-10279)? Or did I screw up my setup the second time too?
      

      So far it seems nothing bad will happen, still the edit display is confusing and needs to be improved.

            Unassigned Unassigned
            chaban chaban
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:

                Version Package