Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-10605

Refactor rendering of external links in the sidebar

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Data display

      Currently, external links displayed in the sidebar of entity page are created using subroutine sidebar_name defined in Perl under lib/MusicBrainz/Server/Entity/URL/.

      • It is a minor breach of MVC pattern as it should belong to the View component under root/.
      • A bit more annoying, it prevents implementing smart/conditional display of external links in the sidebar because neither the entity it is linked to nor the relationship type it is linked through are provided when computing sidebar_name.

      Since relationship type and related entity are already available to the component ExternalLinks in React under root/layout/components/ExternalLinks.js, it seems easier to follow MVC pattern by moving the computation of sidebar_name from Perl to JavaScript, thus allowing for improvements of external links' sidebar display.

            Unassigned Unassigned
            yvanzo yvanzo
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Version Package