Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-10696

Generalize the [No lyrics] work language name fallback for the zxx ISO code

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None

      We display [No lyrics] for zxx (in place of "No linguistic content") in various places for works:

      $ git grep -F '[No lyrics]'
lib/MusicBrainz/Server/Data/Language.pm:                $wl->language->name(l("[No lyrics]"));
lib/MusicBrainz/Server/Edit/Work/Create.pm:                    $language->name(l("[No lyrics]"));
lib/MusicBrainz/Server/Edit/Work/Edit.pm:                        $language->name(l("[No lyrics]"));
lib/MusicBrainz/Server/Form/Utils.pm:                $language->name(l("[No lyrics]"));

      And soon to be in https://github.com/metabrainz/musicbrainz-server/pull/1421

      It'd be nice to consolidate these somehow. Perhaps by adding a name method to WorkLanguage that returns [No lyrics] in that case, and the underlying language name otherwise.

            Unassigned Unassigned
            bitmap Michael Wiencek
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package