Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-10726

Several release editor buttons say "disc" but really mean "medium"

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2021-04-05
    • Component/s: Release editor
    • Labels:
      None

      Description

      The buttons for collapsing, moving and removing mediums always say "disc". 

      Not every medium format has the form of a disc therefore using the more neutral term "medium" would be better. Also note that "Collapse Disc" uses all caps while the others use sentence case.

      <button type="button" class="icon collapse-disc" data-click="toggleMedium" data-bind="css: { 'expand-disc': collapsed, 'collapse-disc': !collapsed() }, attr: { title: collapsed() ? 'Expand Disc' : 'Collapse Disc' }" title="Collapse Disc"></button>
      <button type="button" class="icon disc-down" title="Move disc down" data-click="moveMediumDown"></button>
      <button type="button" class="icon disc-up" title="Move disc up" data-click="moveMediumUp"></button>
      <button type="button" class="icon remove-item" title="Remove disc" style="margin-left: 16px" data-click="removeMedium"></button>
      

      Furthermore the buttons to move tracks lack any description. For consistency I'd propose use "Move track up/down"

        Attachments

          Activity

            People

            Assignee:
            reosarevok Nicolás Tamargo
            Reporter:
            chaban chaban
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                2021-04-05