Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-10726

Several release editor buttons say "disc" but really mean "medium"

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2021-04-05
    • None
    • Release editor
    • None

      The buttons for collapsing, moving and removing mediums always say "disc". 

      Not every medium format has the form of a disc therefore using the more neutral term "medium" would be better. Also note that "Collapse Disc" uses all caps while the others use sentence case.

      <button type="button" class="icon collapse-disc" data-click="toggleMedium" data-bind="css: { 'expand-disc': collapsed, 'collapse-disc': !collapsed() }, attr: { title: collapsed() ? 'Expand Disc' : 'Collapse Disc' }" title="Collapse Disc"></button>
<button type="button" class="icon disc-down" title="Move disc down" data-click="moveMediumDown"></button>
<button type="button" class="icon disc-up" title="Move disc up" data-click="moveMediumUp"></button>
<button type="button" class="icon remove-item" title="Remove disc" style="margin-left: 16px" data-click="removeMedium"></button>

      Furthermore the buttons to move tracks lack any description. For consistency I'd propose use "Move track up/down"

            reosarevok Nicolás Tamargo
            chaban chaban
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2021-04-05