Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-10829

Indexed recording search fails to find recording with no length

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2020-11-02
    • None
    • Search
    • None

      I was importing this release : 
      https://www.discogs.com/Various-Homegrown-Cupboard-Music/release/53638

      Into musicbrainz and noticed some sub-optimal behavior with regards to the recording search on the "Recordings" tab of the release editor.

      Briefly :

      1) all of the recordings on the release were already in musicbrainz, because the release is a CD compilation of tracks from previous vinyl releases
      2) because the existing recordings are all from vinyl, their durations are all (?:??)
      3) perhaps because of 2, none of them are returned in indexed search at all
      4) when I switched to direct search, they would be returned. however on track 7, "Black Cat," the results did not appear to suggest a constraint on artist name... so after being unable to locate my release in the first 7 pages of slow direct search results,  I gave up and just copy/pasted from the release page for the vinyl release.

      In summary :

      • It is unexpected that indexed search does not return "exact artist-name+exact recording title" matches under some circumstances. It seems especially odd because on the recording tab the artist-name constraint is already hydrated with a mbid.
      • It is unexpected that direct search does not return "exact artist-name+exact recording title" matches first.

      As an aside, I wonder how many duplicate recordings I have personally created as a result of encountering this case...

          [MBS-10829] Indexed recording search fails to find recording with no length

          Fixed it for indexed (not fully happy with the result but it does seem like a significant improvement).

           

          Direct search is supposed to only look at titles, that's just how it's written. We might get rid of it eventually since the indexed updates basically instantly nowadays anyway, but it can't support something like this in any case.

          Nicolás Tamargo added a comment - Fixed it for indexed (not fully happy with the result but it does seem like a significant improvement).   Direct search is supposed to only look at titles, that's just how it's written. We might get rid of it eventually since the indexed updates basically instantly nowadays anyway, but it can't support something like this in any case.

          GitHub Bot added a comment -

          See code changes in pull request #1518 submitted by reosarevok.

          GitHub Bot added a comment - See code changes in pull request #1518 submitted by reosarevok .

          yvanzo added a comment -

          Note that “Direct database search” is not using the search server. It seems more likely that is an issue about how the MusicBrainz Server writes queries.

          yvanzo added a comment - Note that “Direct database search” is not using the search server. It seems more likely that is an issue about how the MusicBrainz Server writes queries.

            reosarevok Nicolás Tamargo
            darwinx0r nope
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2020-11-02