Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-11264

Guess Case > French mode > chain of c combined with ' incorrectly convert it in uppercase

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2021-01-11
    • None
    • Guess case
    • None

      Hi,

      I recently noticed that the French mode for guess case button convert "c'est" as "C'est" even if it's in a middle of a sentence, example:

      "Léon, où c'est-y qu't'es donc ?" will be incorrectly convert as "Léon, où C'est-y qu't'es donc ?"

      Recording "Léon, où c'est-y qu't'es donc ?" by Charles Trenet - MusicBrainz

          [MBS-11264] Guess Case > French mode > chain of c combined with ' incorrectly convert it in uppercase

          Yeah, turns out we had two bugs on top of each other: one special case for C (my own fault!) that was added to uppercase "C'mon" and similar words in English (but we were running all the special cases for English on all languages) and then the general issue with Roman numerals and apostrophes (so, even after fixing the first bug, the Roman numeral code would still uppercase "C'est"). Sent changes to both. Thanks for helping along!

          Nicolás Tamargo added a comment - Yeah, turns out we had two bugs on top of each other: one special case for C (my own fault!) that was added to uppercase "C'mon" and similar words in English (but we were running all the special cases for English on all languages) and then the general issue with Roman numerals and apostrophes (so, even after fixing the first bug, the Roman numeral code would still uppercase "C'est"). Sent changes to both. Thanks for helping along!

          GitHub Bot added a comment -

          See code changes in pull request #1817 submitted by reosarevok.

          GitHub Bot added a comment - See code changes in pull request #1817 submitted by reosarevok .

          Fabien added a comment -

          From my side I can confirm I never had this problem with "d'" except If I check the Roman numerals of course

          Fabien added a comment - From my side I can confirm I never had this problem with "d'" except If I check the Roman numerals of course

          Hah, then there's two similar issues (chanson d'été will become Chanson D'été with Roman numerals active but Chanson d'été without them). Checking, anyway.

          Nicolás Tamargo added a comment - Hah, then there's two similar issues (chanson d'été will become Chanson D'été with Roman numerals active but Chanson d'été without them). Checking, anyway.

          Fabien added a comment -

          Uppercase Roman numerals is uncheck, I can confirm.

           

          Fabien added a comment - Uppercase Roman numerals is uncheck, I can confirm.  

          I don't think this is about French mode - do you have Roman numerals on? "C" is a Roman numeral, and it sees ' as the start of a new word.

          That said, I doubt we ever have legit Roman numerals followed by ' so we should probably change the code to skip those here

          Nicolás Tamargo added a comment - I don't think this is about French mode - do you have Roman numerals on? "C" is a Roman numeral, and it sees ' as the start of a new word. That said, I doubt we ever have legit Roman numerals followed by ' so we should probably change the code to skip those here

            reosarevok Nicolás Tamargo
            fabe56 Fabien
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2021-01-11