Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-11391

Show changes made to external link when editing URL relationship

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2021-09-06
    • Component/s: Editing interface
    • Labels:
      None

      Description

      When adding (or editing) external links for an artist (or any other type of entity), some entered URLs get automatically changed for normalization.
      For example:

      http://wikipedia.org/wiki/Ramesh_Vinayakam?oldformat=true

      is overwritten with:

      https://en.wikipedia.org/wiki/Ramesh_Vinayakam

      These changes are implicit and difficult to see for editors. These changes can be bugged, can prevent editors from entering some characters, can become outdated when external websites change their URL formats (anytime). They make change to editor’s input without notice which makes difficult to detect errors. So it would be more helpful to have separate display for the URL entered by the editor and the normalized URL.

      Eventually a popover is implemented for editing URL and comparing raw input with cleaned-up URL. The URL input boxes in the link list are replaced with clickable links. Now that there's a clickable link, the URL in relationship type description tooltip can be safely removed, therefore solving the text overflow issue.

      While there're other options like inline text and bubbles, we determined that a popover is a better choice after a discussion on the forum and IRC channel. In general a popover provides more flexibility and possibility than the bubble, and makes the interface more compact than inline text.

      After this change, newly added link will be added to the list when the user presses Enter/Tab or when the input box loses focus. Links in the list can be edited in the popover opened by clicking the edit icon, in which users can preview the URL after clean-up, see the original URL and errors related to it. They can save the changes by pressing Enter, clicking 'Done' button or cliking outside the popover, they may also discard changes by clicking 'Cancel'. The link list displays clean URLs to be submitted eventually.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              yyoung yyoung
              Reporter:
              yvanzo yvanzo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Packages

                  Version Package
                  2021-09-06