Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-11485

Allow irc(s):// links on expand2react

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2021-04-05
    • Component/s: Data display
    • Labels:
      None

      Description

      The main issue in the error below seems to be that the IRC links are not supported by expand2react. I see no reason why we shouldn't allow them though.

      https://sentry.metabrainz.org/metabrainz/musicbrainz-server/issues/101586/?referrer=jira_plugin

      Error: Failed to parse string "<p>I can understand English, but writing is so bad. sorry.<br />\nCatch me on IRC in <a href=\"//wiki.musicbrainz.org/%3Ca%20href%3D%22irc%3A%2F%2Firc.freenode.net%2Fmusicbrainz%22%20rel%3D%22nofollow%22%3E%23musicbrainz%3C%2F...
        File "/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js", line 1, in b
          '{snip} (e.length),t.length>1?t[1]:e}return c}function b(e){return new Error(`Failed to parse string ${JSON.stringify(d.source)} at position ${d.pos {snip}
        File "/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js", line 1, in Array.I
          '{snip} )('expected "');if("href"===t&&!f.test(s))throw Object(a.h)("bad href value");const n={};return n[t]=s,n}];function $(e){if(!Object(a.j)(Obj {snip}
        File "/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js", line 1, in p
          '{snip} r=!0;for(;r;){r=!1;for(let n=0;n<e.length;n++){const c=e[n](t);if(a(c)){if(i=s(i,c),!d.remainder)break;r=!0}}}return a(i)?i:n}function x(e,t {snip}
        File "/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js", line 1, in C
          '{snip} s]);else T(e,t);return e}function C(e,t){return Object(a.k)(e,t,k,l)}const S=Object(a.d)(e=>Object(a.l)(A,e),e=>Object(a.l)(R,e)),A=[Object( {snip}
        File "/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js", line 1, in Array.$
          '{snip} tring"!=typeof t)throw Object(a.h)("bad HTML tag");const s=C(I,e);if(Object(a.j)(Object(a.c)(p)))return r.createElement(t,Object.assign({},. {snip}
      ...
      (5 additional frame(s) were not displayed)
      

        Attachments

          Activity

            People

            Assignee:
            reosarevok Nicolás Tamargo
            Reporter:
            dev-sentry Dev through Sentry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Packages

                Version Package
                2021-04-05